chrome/browser/plugins/plugin_installer.h - Issue 22918027: Remove calls to ObserverList::size() from PluginInstaller.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/plugins/plugin_installer.h

Issue 22918027: Remove calls to ObserverList::size() from PluginInstaller. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « no previous file | chrome/browser/plugins/plugin_installer.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_BROWSER_PLUGINS_PLUGIN_INSTALLER_H_	5 #ifndef CHROME_BROWSER_PLUGINS_PLUGIN_INSTALLER_H_

6 #define CHROME_BROWSER_PLUGINS_PLUGIN_INSTALLER_H_	6 #define CHROME_BROWSER_PLUGINS_PLUGIN_INSTALLER_H_

7	7

8 #include "base/observer_list.h"	8 #include "base/observer_list.h"

9 #include "base/strings/string16.h"	9 #include "base/strings/string16.h"

10 #include "base/version.h"	10 #include "base/version.h"

(...skipping 40 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
51 void StartInstalling(const GURL& plugin_url,	51 void StartInstalling(const GURL& plugin_url,

52 content::WebContents* web_contents);	52 content::WebContents* web_contents);

53	53

54 private:	54 private:

55 void DownloadStarted(content::DownloadItem* item, net::Error error);	55 void DownloadStarted(content::DownloadItem* item, net::Error error);

56 void DownloadError(const std::string& msg);	56 void DownloadError(const std::string& msg);

57 void DownloadCancelled();	57 void DownloadCancelled();

58	58

59 InstallerState state_;	59 InstallerState state_;

60 ObserverList<PluginInstallerObserver> observers_;	60 ObserverList<PluginInstallerObserver> observers_;

	61 int strong_observer_count_;

61 ObserverList<WeakPluginInstallerObserver> weak_observers_;	62 ObserverList<WeakPluginInstallerObserver> weak_observers_;

62	63

63 DISALLOW_COPY_AND_ASSIGN(PluginInstaller);	64 DISALLOW_COPY_AND_ASSIGN(PluginInstaller);

64 };	65 };

65	66

66 #endif // CHROME_BROWSER_PLUGINS_PLUGIN_INSTALLER_H_	67 #endif // CHROME_BROWSER_PLUGINS_PLUGIN_INSTALLER_H_

OLD	NEW