Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Issue 22918026: Porting WebKit 114900 to blink: checkLayout() should error out if no data-expected* attributes were… (Closed)

Created:
7 years, 4 months ago by r.kasibhatla
Modified:
7 years, 3 months ago
Reviewers:
ojan, eseidel
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Porting WebKit 114900 to blink: checkLayout() should error out if no data-expected* attributes were found BUG=233956 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156648

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -23 lines) Patch
A LayoutTests/fast/check-layout-error-no-attributes.html View 1 chunk +11 lines, -0 lines 0 comments Download
A LayoutTests/fast/check-layout-error-no-attributes-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/resources/check-layout.js View 11 chunks +41 lines, -23 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
r.kasibhatla
7 years, 4 months ago (2013-08-23 14:40:46 UTC) #1
ojan
lgtm
7 years, 4 months ago (2013-08-23 16:58:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/r.kasibhatla@samsung.com/22918026/1
7 years, 4 months ago (2013-08-23 16:58:31 UTC) #3
commit-bot: I haz the power
7 years, 4 months ago (2013-08-23 18:19:55 UTC) #4
Message was sent while issue was closed.
Change committed as 156648

Powered by Google App Engine
This is Rietveld 408576698