Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(872)

Unified Diff: sdk/lib/core/invocation.dart

Issue 22918025: Make Invocation.positionalArguments and .namedArguments never be null. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/_internal/lib/js_helper.dart ('k') | tests/language/invocation_mirror_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/core/invocation.dart
diff --git a/sdk/lib/core/invocation.dart b/sdk/lib/core/invocation.dart
index 0388e21965e395d6b24e0f70a1861bb3372f90bc..73ee7ab7d244641a33ab958d919d0e8e14b34e3e 100644
--- a/sdk/lib/core/invocation.dart
+++ b/sdk/lib/core/invocation.dart
@@ -15,10 +15,19 @@ abstract class Invocation {
/** The name of the invoked member. */
Symbol get memberName;
- /** An unmodifiable view of the positional arguments of the call. */
+ /**
+ * An unmodifiable view of the positional arguments of the call.
+ *
+ * If the member is a getter, the positional arguments will be empty.
floitsch 2013/08/23 16:10:03 is empty.
+ */
List get positionalArguments;
- /** An unmodifiable view of the named arguments of the call. */
+ /**
+ * An unmodifiable view of the named arguments of the call.
+ *
+ * If the member is a getter, setter or operator, the named arguments
floitsch 2013/08/23 16:10:03 is empty.
+ * will be empty.
+ */
Map<Symbol, dynamic> get namedArguments;
/** Whether the invocation was a method call. */
@@ -26,7 +35,7 @@ abstract class Invocation {
/**
* Whether the invocation was a getter call.
- * If so, both types of arguments will be null.
+ * If so, both types of arguments will be empty.
floitsch 2013/08/23 16:10:03 is empty.
*/
bool get isGetter;
@@ -34,7 +43,7 @@ abstract class Invocation {
* Whether the invocation was a setter call.
*
* If so, [arguments] will have exactly one positonal argument,
- * and namedArguments will be null.
+ * and namedArguments will be empty.
floitsch 2013/08/23 16:10:03 has exactly ... is empty.
*/
bool get isSetter;
« no previous file with comments | « sdk/lib/_internal/lib/js_helper.dart ('k') | tests/language/invocation_mirror_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698