Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(620)

Unified Diff: scripts/slave/recipe_modules/v8/gclient_config.py

Issue 2291793002: Stop referencing svn urls in gclient recipe configs (Closed)
Patch Set: Rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___debug_builder.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipe_modules/v8/gclient_config.py
diff --git a/scripts/slave/recipe_modules/v8/gclient_config.py b/scripts/slave/recipe_modules/v8/gclient_config.py
index 7cf56813416439f24635e181feaa86bb3e08750a..b2de0c6e623981d3b2e3d89347b5d6ac0cf50337 100644
--- a/scripts/slave/recipe_modules/v8/gclient_config.py
+++ b/scripts/slave/recipe_modules/v8/gclient_config.py
@@ -4,14 +4,14 @@
import DEPS
CONFIG_CTX = DEPS['gclient'].CONFIG_CTX
-from recipe_engine.config import BadConf
+ChromiumGitURL = DEPS['gclient'].config.ChromiumGitURL
@CONFIG_CTX()
def v8(c):
soln = c.solutions.add()
soln.name = 'v8'
- soln.url = 'https://chromium.googlesource.com/v8/v8'
+ soln.url = ChromiumGitURL(c, 'v8', 'v8')
c.got_revision_mapping['v8'] = 'got_revision'
# Needed to get the testers to properly sync the right revision.
# TODO(infra): Upload full buildspecs for every build to isolate and then use
@@ -26,20 +26,20 @@ def v8(c):
def dynamorio(c):
soln = c.solutions.add()
soln.name = 'dynamorio'
- soln.url = 'https://chromium.googlesource.com/external/dynamorio'
+ soln.url = ChromiumGitURL(c, 'external', 'dynamorio')
@CONFIG_CTX(includes=['v8'])
def llvm_compiler_rt(c):
c.solutions[0].custom_deps['v8/third_party/llvm/projects/compiler-rt'] = (
- 'https://chromium.googlesource.com/external/llvm.org/compiler-rt.git')
+ ChromiumGitURL(c, 'external', 'llvm.org', 'compiler-rt'))
@CONFIG_CTX()
def node_js(c):
soln = c.solutions.add()
soln.name = 'node.js'
- soln.url = 'https://chromium.googlesource.com/external/github.com/v8/node'
+ soln.url = ChromiumGitURL(c, 'external', 'github.com', 'v8', 'node')
soln.revision = 'vee-eight-lkgr:HEAD'
c.got_revision_mapping[soln.name] = 'got_node_js_revision'
@@ -47,4 +47,4 @@ def node_js(c):
@CONFIG_CTX(includes=['v8'])
def v8_valgrind(c):
c.solutions[0].custom_deps['v8/third_party/valgrind'] = (
- 'https://chromium.googlesource.com/chromium/deps/valgrind/binaries.git')
+ ChromiumGitURL(c, 'chromium', 'deps', 'valgrind', 'binaries'))
« no previous file with comments | « no previous file | scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___debug_builder.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698