Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Unified Diff: gpu/command_buffer/service/feature_info_unittest.cc

Issue 2291753002: Prevent crash when using getExtension while a PBO is bound. (Closed)
Patch Set: small corrections Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/service/feature_info_unittest.cc
diff --git a/gpu/command_buffer/service/feature_info_unittest.cc b/gpu/command_buffer/service/feature_info_unittest.cc
index 2643e6e346920466c74bcc1436f262d1edd5d21b..44ebd03993f631f8269544fe3fa08134d4ba7c06 100644
--- a/gpu/command_buffer/service/feature_info_unittest.cc
+++ b/gpu/command_buffer/service/feature_info_unittest.cc
@@ -95,7 +95,7 @@ class FeatureInfoTest
const char* extensions, const char* renderer, const char* version) {
GpuServiceTest::SetUpWithGLVersion(version, extensions);
TestHelper::SetupFeatureInfoInitExpectationsWithGLVersion(
- gl_.get(), extensions, renderer, version);
+ gl_.get(), extensions, renderer, version, GetContextType());
info_ = new FeatureInfo();
info_->Initialize(GetContextType(), DisallowedFeatures());
}
@@ -107,7 +107,7 @@ class FeatureInfoTest
const DisallowedFeatures& disallowed_features) {
GpuServiceTest::SetUpWithGLVersion(version, extensions);
TestHelper::SetupFeatureInfoInitExpectationsWithGLVersion(
- gl_.get(), extensions, renderer, version);
+ gl_.get(), extensions, renderer, version, GetContextType());
info_ = new FeatureInfo();
info_->Initialize(GetContextType(), disallowed_features);
}
@@ -119,7 +119,7 @@ class FeatureInfoTest
const base::CommandLine& command_line) {
GpuServiceTest::SetUpWithGLVersion(version, extensions);
TestHelper::SetupFeatureInfoInitExpectationsWithGLVersion(
- gl_.get(), extensions, renderer, version);
+ gl_.get(), extensions, renderer, version, GetContextType());
GpuDriverBugWorkarounds gpu_driver_bug_workaround(&command_line);
info_ = new FeatureInfo(command_line, gpu_driver_bug_workaround);
info_->Initialize(GetContextType(), DisallowedFeatures());
@@ -136,7 +136,7 @@ class FeatureInfoTest
const base::CommandLine& command_line) {
GpuServiceTest::SetUpWithGLVersion("2.0", extensions);
TestHelper::SetupFeatureInfoInitExpectationsWithGLVersion(
- gl_.get(), extensions, "", "");
+ gl_.get(), extensions, "", "", GetContextType());
GpuDriverBugWorkarounds gpu_driver_bug_workaround(&command_line);
info_ = new FeatureInfo(command_line, gpu_driver_bug_workaround);
info_->Initialize(GetContextType(), DisallowedFeatures());
« no previous file with comments | « gpu/command_buffer/service/feature_info.cc ('k') | gpu/command_buffer/service/framebuffer_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698