Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(618)

Unified Diff: gpu/command_buffer/service/context_group_unittest.cc

Issue 2291753002: Prevent crash when using getExtension while a PBO is bound. (Closed)
Patch Set: small corrections Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | gpu/command_buffer/service/feature_info.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/command_buffer/service/context_group_unittest.cc
diff --git a/gpu/command_buffer/service/context_group_unittest.cc b/gpu/command_buffer/service/context_group_unittest.cc
index 36934c73501a8cafc3cab56f8f1656cd316ecfc8..4bf94cca8b0650e7203965102faf3281fd28929b 100644
--- a/gpu/command_buffer/service/context_group_unittest.cc
+++ b/gpu/command_buffer/service/context_group_unittest.cc
@@ -71,7 +71,8 @@ TEST_F(ContextGroupTest, Basic) {
TEST_F(ContextGroupTest, InitializeNoExtensions) {
TestHelper::SetupContextGroupInitExpectations(
- gl_.get(), DisallowedFeatures(), "", "", kBindGeneratesResource);
+ gl_.get(), DisallowedFeatures(), "", "",
+ CONTEXT_TYPE_OPENGLES2, kBindGeneratesResource);
group_->Initialize(decoder_.get(), CONTEXT_TYPE_OPENGLES2,
DisallowedFeatures());
EXPECT_EQ(static_cast<uint32_t>(TestHelper::kNumVertexAttribs),
@@ -107,7 +108,8 @@ TEST_F(ContextGroupTest, InitializeNoExtensions) {
TEST_F(ContextGroupTest, MultipleContexts) {
std::unique_ptr<MockGLES2Decoder> decoder2_(new MockGLES2Decoder());
TestHelper::SetupContextGroupInitExpectations(
- gl_.get(), DisallowedFeatures(), "", "", kBindGeneratesResource);
+ gl_.get(), DisallowedFeatures(), "", "",
+ CONTEXT_TYPE_OPENGLES2, kBindGeneratesResource);
EXPECT_TRUE(group_->Initialize(decoder_.get(), CONTEXT_TYPE_OPENGLES2,
DisallowedFeatures()));
EXPECT_FALSE(group_->Initialize(decoder2_.get(), CONTEXT_TYPE_WEBGL1,
« no previous file with comments | « no previous file | gpu/command_buffer/service/feature_info.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698