Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 2291743002: Initialize the CPDF_Document pointer (Closed)

Created:
4 years, 3 months ago by dsinclair
Modified:
4 years, 3 months ago
Reviewers:
Lei Zhang, Wei Li
CC:
pdfium-reviews_googlegroups.com, npm
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Initialize the CPDF_Document pointer This CL is a speculative fix for the associated BUG. Make sure the CPDF_Document is initialized in the constructor. BUG=chromium:640998 Committed: https://pdfium.googlesource.com/pdfium/+/e8ae48361bd0a4d8df47d925156b4159658a7941

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M core/fpdfapi/fpdf_parser/cpdf_parser.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (6 generated)
dsinclair
PTAL.
4 years, 3 months ago (2016-08-29 18:25:13 UTC) #4
Lei Zhang
lgtm
4 years, 3 months ago (2016-08-29 18:26:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2291743002/1
4 years, 3 months ago (2016-08-29 18:27:11 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-08-29 18:52:15 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/e8ae48361bd0a4d8df47d925156b4159658a...

Powered by Google App Engine
This is Rietveld 408576698