New parser mode for CSSOM @viewport descriptors.

Source/core/css/CSSParser-in.cpp

 /*
  * Copyright (C) 2003 Lars Knoll (knoll@kde.org)
  * Copyright (C) 2005 Allan Sandfeld Jensen (kde@carewolf.com)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
  * Copyright (C) 2007 Nicholas Shanks <webkit@nickshanks.com>
  * Copyright (C) 2008 Eric Seidel <eric@webkit.org>
  * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  * Copyright (C) 2012 Adobe Systems Incorporated. All rights reserved.
  * Copyright (C) 2012 Intel Corporation. All rights reserved.
  *
@@ skipping 525 matching lines @@
     // not represent a double.
     bool ok;
     number = charactersToDouble(characters, length, &ok);
     return ok;
 }
 
 static bool parseSimpleLengthValue(MutableStylePropertySet* declaration, CSSPropertyID propertyId, const String& string, bool important, CSSParserMode cssParserMode)
 {
     ASSERT(!string.isEmpty());
     bool acceptsNegativeNumbers;
-    if (!isSimpleLengthPropertyID(propertyId, acceptsNegativeNumbers))
+    if (cssParserMode == ViewportMode || !isSimpleLengthPropertyID(propertyId, acceptsNegativeNumbers))

[eseidel, 2013/09/17 16:28:55]

So this whole change is to disallow negative numbers?  Which is more strict than
normal strict mode?

[rune, 2013/09/17 20:17:03]

No. This is to avoid the simple-length-fast-path for "width", which is a
shorthand descriptor in @viewport and cannot be parsed as a simple length.

         return false;
 
     unsigned length = string.length();
     double number;
     CSSPrimitiveValue::UnitTypes unit = CSSPrimitiveValue::CSS_NUMBER;
 
     if (string.is8Bit()) {
         if (!parseSimpleLength(string.characters8(), length, unit, number))
             return false;
     } else {
@@ skipping 654 matching lines @@
     if (m_useCounter)
         m_useCounter->count(propertyID);
 
     setStyleSheet(contextStyleSheet);
 
     setupParser("@-internal-value ", string, "");
 
     m_id = propertyID;
     m_important = important;
 
+    StyleDeclarationScope scope(this, declaration);
     cssyyparse(this);

[eseidel, 2013/09/17 16:28:55]

I might have wrapped this in a block, depending on how long you want the scope
to live for after the parse.

[rune, 2013/09/17 20:17:03]

Will do.

[rune, 2013/09/17 20:40:41]

Done.

 
     m_rule = 0;
     m_id = CSSPropertyInvalid;
 
     bool ok = false;
     if (m_hasFontFaceOnlyValues)
         deleteFontFaceOnlyValues();
     if (!m_parsedProperties.isEmpty()) {
         ok = true;
         declaration->addParsedProperties(m_parsedProperties);
@@ skipping 94 matching lines @@
     setStyleSheet(contextStyleSheet);
 
     m_sourceDataHandler = sourceDataHandler;
 
     setupParser("@-internal-decls ", string, "");
     if (m_sourceDataHandler) {
         m_sourceDataHandler->startRuleHeader(CSSRuleSourceData::STYLE_RULE, 0);
         m_sourceDataHandler->endRuleHeader(1);
         m_sourceDataHandler->startRuleBody(0);
     }
+
+    StyleDeclarationScope scope(this, declaration);
     cssyyparse(this);
+
     m_rule = 0;
 
     bool ok = false;
     if (m_hasFontFaceOnlyValues)
         deleteFontFaceOnlyValues();
     if (!m_parsedProperties.isEmpty()) {
         ok = true;
         declaration->addParsedProperties(m_parsedProperties);
         clearProperties();
     }
@@ skipping 46 matching lines @@
     size_t unusedEntries = m_parsedProperties.size();
     Vector<CSSProperty, 256> results(unusedEntries);
 
     // Important properties have higher priority, so add them first. Duplicate definitions can then be ignored when found.
     HashSet<AtomicString> seenVariables;
     filterProperties(true, m_parsedProperties, results, unusedEntries, seenProperties, seenVariables);
     filterProperties(false, m_parsedProperties, results, unusedEntries, seenProperties, seenVariables);
     if (unusedEntries)
         results.remove(0, unusedEntries);
 
-    return ImmutableStylePropertySet::create(results.data(), results.size(), m_context.mode);
+    CSSParserMode mode = inViewport() ? ViewportMode : m_context.mode;
+
+    return ImmutableStylePropertySet::create(results.data(), results.size(), mode);
 }
 
 void CSSParser::addPropertyWithPrefixingVariant(CSSPropertyID propId, PassRefPtr<CSSValue> value, bool important, bool implicit)
 {
     RefPtr<CSSValue> val = value.get();
     addProperty(propId, value, important, implicit);
 
     CSSPropertyID prefixingVariant = prefixingVariantForPropertyId(propId);
     if (prefixingVariant == propId)
         return;
@@ skipping 10575 matching lines @@
 {
     // The tokenizer checks for the construct of an+b.
     // However, since the {ident} rule precedes the {nth} rule, some of those
     // tokens are identified as string literal. Furthermore we need to accept
     // "odd" and "even" which does not match to an+b.
     return equalIgnoringCase(token, "odd") || equalIgnoringCase(token, "even")
         || equalIgnoringCase(token, "n") || equalIgnoringCase(token, "-n");
 }
 
 }