Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 2291693002: Remove obsolete ChromeOS DBus bindings for privetd (Closed)

Created:
4 years, 3 months ago by Ben Chan
Modified:
4 years, 3 months ago
Reviewers:
stevenjb, hashimoto
CC:
chromium-reviews, hashimoto+watch_chromium.org, oshima+watch_chromium.org, satorux1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove obsolete ChromeOS DBus bindings for privetd This CL removes the obsolete ChromeOS DBus bindings for privetd that was introduced in https://crrev.com/ab7987e2b286aead19236e89718f8cd97b242ec1 (see crbug.com/467018). The corresponding privetd DBus daemon was removed from ChromeOS (crosreview.com/277705). BUG=None TEST=chromeos_unittests R=stevenjb@chromium.org Committed: https://crrev.com/48a9459b9f1de00b2ca2540ae9f6273d6cce67cf Cr-Commit-Position: refs/heads/master@{#415028}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -610 lines) Patch
M chromeos/chromeos.gyp View 3 chunks +0 lines, -5 lines 0 comments Download
M chromeos/dbus/dbus_client_bundle.h View 4 chunks +1 line, -8 lines 0 comments Download
M chromeos/dbus/dbus_client_bundle.cc View 4 chunks +0 lines, -8 lines 0 comments Download
M chromeos/dbus/dbus_thread_manager.h View 3 chunks +0 lines, -4 lines 0 comments Download
M chromeos/dbus/dbus_thread_manager.cc View 4 chunks +0 lines, -12 lines 0 comments Download
D chromeos/dbus/fake_privet_daemon_manager_client.h View 1 chunk +0 lines, -36 lines 0 comments Download
D chromeos/dbus/fake_privet_daemon_manager_client.cc View 1 chunk +0 lines, -39 lines 0 comments Download
D chromeos/dbus/privet_daemon_manager_client.h View 1 chunk +0 lines, -157 lines 0 comments Download
D chromeos/dbus/privet_daemon_manager_client.cc View 1 chunk +0 lines, -283 lines 0 comments Download
D chromeos/dbus/privet_daemon_manager_client_unittest.cc View 1 chunk +0 lines, -58 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Ben Chan
4 years, 3 months ago (2016-08-29 16:36:18 UTC) #5
stevenjb
lgtm
4 years, 3 months ago (2016-08-29 16:48:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2291693002/1
4 years, 3 months ago (2016-08-29 17:44:02 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-08-29 20:14:39 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/48a9459b9f1de00b2ca2540ae9f6273d6cce67cf
Cr-Commit-Position: refs/heads/master@{#415028}

Powered by Google App Engine
This is Rietveld 408576698