Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Issue 229163004: [Mac] Move profile related UI from cocoa/browser to cocoa/profiles (Closed)

Created:
6 years, 8 months ago by noms (inactive)
Modified:
6 years, 8 months ago
Reviewers:
Nico
CC:
chromium-reviews
Visibility:
Public.

Description

[Mac] Move profile related UI from cocoa/browser to cocoa/profiles BUG=NONE TEST=Existing unit tests. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262826

Patch Set 1 : #

Patch Set 2 : oops forgot a comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -5942 lines) Patch
M chrome/browser/app_controller_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/app_controller_mac_browsertest.mm View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/ui/cocoa/browser/avatar_base_controller.h View 1 chunk +0 lines, -52 lines 0 comments Download
D chrome/browser/ui/cocoa/browser/avatar_base_controller.mm View 1 chunk +0 lines, -173 lines 0 comments Download
D chrome/browser/ui/cocoa/browser/avatar_button_controller.h View 1 chunk +0 lines, -26 lines 0 comments Download
D chrome/browser/ui/cocoa/browser/avatar_button_controller.mm View 1 chunk +0 lines, -231 lines 0 comments Download
D chrome/browser/ui/cocoa/browser/avatar_button_controller_unittest.mm View 1 chunk +0 lines, -73 lines 0 comments Download
D chrome/browser/ui/cocoa/browser/avatar_icon_controller.h View 1 chunk +0 lines, -38 lines 0 comments Download
D chrome/browser/ui/cocoa/browser/avatar_icon_controller.mm View 1 chunk +0 lines, -241 lines 0 comments Download
D chrome/browser/ui/cocoa/browser/avatar_icon_controller_unittest.mm View 1 chunk +0 lines, -123 lines 0 comments Download
D chrome/browser/ui/cocoa/browser/avatar_label_button.h View 1 chunk +0 lines, -23 lines 0 comments Download
D chrome/browser/ui/cocoa/browser/avatar_label_button.mm View 1 chunk +0 lines, -135 lines 0 comments Download
D chrome/browser/ui/cocoa/browser/avatar_label_button_unittest.mm View 1 chunk +0 lines, -32 lines 0 comments Download
D chrome/browser/ui/cocoa/browser/avatar_menu_bubble_controller.h View 1 chunk +0 lines, -141 lines 0 comments Download
D chrome/browser/ui/cocoa/browser/avatar_menu_bubble_controller.mm View 1 chunk +0 lines, -719 lines 0 comments Download
D chrome/browser/ui/cocoa/browser/avatar_menu_bubble_controller_unittest.mm View 1 chunk +0 lines, -270 lines 0 comments Download
D chrome/browser/ui/cocoa/browser/profile_chooser_controller.h View 1 chunk +0 lines, -123 lines 0 comments Download
D chrome/browser/ui/cocoa/browser/profile_chooser_controller.mm View 1 chunk +0 lines, -1383 lines 0 comments Download
D chrome/browser/ui/cocoa/browser/profile_chooser_controller_unittest.mm View 1 chunk +0 lines, -313 lines 0 comments Download
D chrome/browser/ui/cocoa/browser/user_manager_mac_unittest.mm View 1 chunk +0 lines, -47 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_cocoa.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller.mm View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller_private.mm View 2 chunks +2 lines, -2 lines 0 comments Download
D chrome/browser/ui/cocoa/profile_menu_controller.h View 1 chunk +0 lines, -60 lines 0 comments Download
D chrome/browser/ui/cocoa/profile_menu_controller.mm View 1 chunk +0 lines, -258 lines 0 comments Download
D chrome/browser/ui/cocoa/profile_menu_controller_unittest.mm View 1 chunk +0 lines, -290 lines 0 comments Download
D chrome/browser/ui/cocoa/profile_signin_confirmation_dialog_cocoa.h View 1 chunk +0 lines, -60 lines 0 comments Download
D chrome/browser/ui/cocoa/profile_signin_confirmation_dialog_cocoa.mm View 1 chunk +0 lines, -93 lines 0 comments Download
D chrome/browser/ui/cocoa/profile_signin_confirmation_view_controller.h View 1 chunk +0 lines, -71 lines 0 comments Download
D chrome/browser/ui/cocoa/profile_signin_confirmation_view_controller.mm View 1 chunk +0 lines, -446 lines 0 comments Download
D chrome/browser/ui/cocoa/profile_signin_confirmation_view_controller_browsertest.mm View 1 chunk +0 lines, -186 lines 0 comments Download
A + chrome/browser/ui/cocoa/profiles/avatar_base_controller.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/cocoa/profiles/avatar_base_controller.mm View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/cocoa/profiles/avatar_button_controller.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/ui/cocoa/profiles/avatar_button_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/cocoa/profiles/avatar_button_controller_unittest.mm View 2 chunks +2 lines, -2 lines 0 comments Download
A + chrome/browser/ui/cocoa/profiles/avatar_icon_controller.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/ui/cocoa/profiles/avatar_icon_controller.mm View 2 chunks +2 lines, -2 lines 0 comments Download
A + chrome/browser/ui/cocoa/profiles/avatar_icon_controller_unittest.mm View 2 chunks +2 lines, -2 lines 0 comments Download
A + chrome/browser/ui/cocoa/profiles/avatar_label_button.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/cocoa/profiles/avatar_label_button.mm View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/cocoa/profiles/avatar_label_button_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/cocoa/profiles/avatar_menu_bubble_controller.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/cocoa/profiles/avatar_menu_bubble_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/cocoa/profiles/avatar_menu_bubble_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/cocoa/profiles/profile_chooser_controller.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm View 2 chunks +2 lines, -2 lines 0 comments Download
A + chrome/browser/ui/cocoa/profiles/profile_chooser_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/cocoa/profiles/profile_menu_controller.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/cocoa/profiles/profile_menu_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/cocoa/profiles/profile_menu_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/cocoa/profiles/profile_signin_confirmation_dialog_cocoa.h View 3 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/ui/cocoa/profiles/profile_signin_confirmation_dialog_cocoa.mm View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/cocoa/profiles/profile_signin_confirmation_view_controller.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/cocoa/profiles/profile_signin_confirmation_view_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/cocoa/profiles/profile_signin_confirmation_view_controller_browsertest.mm View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/cocoa/profiles/user_manager_mac.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/cocoa/profiles/user_manager_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/cocoa/profiles/user_manager_mac_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/ui/cocoa/user_manager_mac.h View 1 chunk +0 lines, -62 lines 0 comments Download
D chrome/browser/ui/cocoa/user_manager_mac.mm View 1 chunk +0 lines, -178 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 4 chunks +20 lines, -20 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_tests_unit.gypi View 2 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
noms (inactive)
Hiya Nico, I've moved all the c/b/ui/cocoa/ profile-related classes from /browser to /profiles, as the ...
6 years, 8 months ago (2014-04-08 21:14:16 UTC) #1
noms (inactive)
∩∩ (゚ω゚) ping! │ │ │ └─┐○ ヽ 丿 ∥ ̄∥
6 years, 8 months ago (2014-04-09 18:01:47 UTC) #2
Nico
(How's the views code organized? I don't see chrome/browser/ui/views)
6 years, 8 months ago (2014-04-09 18:05:47 UTC) #3
noms (inactive)
Just did the same refactor over there too: https://codereview.chromium.org/229293002/
6 years, 8 months ago (2014-04-09 18:07:46 UTC) #4
Nico
…but this lgtm, it's better than what we have today.
6 years, 8 months ago (2014-04-09 18:08:12 UTC) #5
Nico
On Wed, Apr 9, 2014 at 11:07 AM, <noms@chromium.org> wrote: > Just did the same ...
6 years, 8 months ago (2014-04-09 18:08:41 UTC) #6
noms (inactive)
The CQ bit was checked by noms@chromium.org
6 years, 8 months ago (2014-04-09 18:14:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noms@chromium.org/229163004/40001
6 years, 8 months ago (2014-04-09 18:15:08 UTC) #8
noms (inactive)
Thanks!
6 years, 8 months ago (2014-04-09 18:15:43 UTC) #9
commit-bot: I haz the power
6 years, 8 months ago (2014-04-09 21:44:03 UTC) #10
Message was sent while issue was closed.
Change committed as 262826

Powered by Google App Engine
This is Rietveld 408576698