Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 2291613002: [api] Add NumberOfWrappersToTrace to EmbedderHeapTracer. (Closed)

Created:
4 years, 3 months ago by Michael Lippautz
Modified:
4 years, 3 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[api] Add NumberOfWrappersToTrace to EmbedderHeapTracer. V8 can use this metter to better estimate the amount of work that is still to be done by the embedder. Supposed to be used to decide whether incremental marking should be finalized or not. BUG=chromium:468240 R=ulan@chromium.org Committed: https://crrev.com/0f01a5881f932fedafa93e08300f6ec429662a8f Cr-Commit-Position: refs/heads/master@{#38985}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -6 lines) Patch
M include/v8.h View 3 chunks +17 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
ulan
lgtm
4 years, 3 months ago (2016-08-29 15:00:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2291613002/1
4 years, 3 months ago (2016-08-29 15:36:26 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-29 15:38:29 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-08-29 15:38:56 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0f01a5881f932fedafa93e08300f6ec429662a8f
Cr-Commit-Position: refs/heads/master@{#38985}

Powered by Google App Engine
This is Rietveld 408576698