Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Unified Diff: tests/compiler/dart2js/simple_inferrer_test.dart

Issue 22916003: Tweak simple_inferrer_test to pass with fix for 12320 (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/compiler/dart2js/simple_inferrer_test.dart
diff --git a/tests/compiler/dart2js/simple_inferrer_test.dart b/tests/compiler/dart2js/simple_inferrer_test.dart
index fc6fe0aba3829f7253ec418062e8daf7b93dd5e8..14ef813474694ef6c7ef24ff0fbea42073270923 100644
--- a/tests/compiler/dart2js/simple_inferrer_test.dart
+++ b/tests/compiler/dart2js/simple_inferrer_test.dart
@@ -544,7 +544,10 @@ void main() {
checkReturn('testLabeledIf', typesTask.intType.nullable());
checkReturn('testSwitch1', typesTask.intType
.union(typesTask.doubleType, compiler).nullable().simplify(compiler));
- checkReturn('testSwitch2', typesTask.intType);
+ // TODO(12320): testSwitch2 should be non-nullable. The quick fix for 12320
+ // models control flow through as though there is an additional empty default
+ // case.
+ checkReturn('testSwitch2', typesTask.intType.nullable());
checkReturn('testSwitch3', interceptorType.nullable());
checkReturn('testSwitch4', typesTask.intType);
checkReturn('testContinue1', interceptorType.nullable());
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698