Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 2291583003: Remove defunct SVN-based gclient configs (Closed)

Created:
4 years, 3 months ago by agable
Modified:
4 years, 3 months ago
Reviewers:
Ryan Tseng, hinoka
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove defunct SVN-based gclient configs The URL helper functions were only used by this file, the svn custom_deps urls aren't referenced in any DEPS files I can find anymore, and the oilpan and buildspec configs aren't used by any recipes. R=hinoka@chromium.org BUG=640251 Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/9741c590a4d4aa65006da2cf764cce6b9d18c0b1

Patch Set 1 #

Patch Set 2 : Don't change custom deps #

Patch Set 3 : Don't remove llvm_url from perf config #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -63 lines) Patch
M recipe_modules/gclient/config.py View 1 2 4 chunks +1 line, -63 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 18 (10 generated)
agable
4 years, 3 months ago (2016-08-29 20:28:03 UTC) #2
Ryan Tseng
lgtm
4 years, 3 months ago (2016-08-29 20:30:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2291583003/1
4 years, 3 months ago (2016-08-29 20:55:25 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Recipe Roll Downstream Tester on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/30f0ee411c0a6710)
4 years, 3 months ago (2016-08-29 21:10:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2291583003/20001
4 years, 3 months ago (2016-08-29 21:28:08 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: Recipe Roll Downstream Tester on luci.infra.try (JOB_FAILED, https://luci-milo.appspot.com/swarming/task/30f1057e33686f10)
4 years, 3 months ago (2016-08-29 21:41:20 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2291583003/40001
4 years, 3 months ago (2016-08-29 22:56:27 UTC) #16
commit-bot: I haz the power
4 years, 3 months ago (2016-08-29 23:03:04 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/9741c590a4d4aa...

Powered by Google App Engine
This is Rietveld 408576698