YuvConstants declare alignment for externs as well as declarations

include/libyuv/row.h

 /*
  *  Copyright 2011 The LibYuv Project Authors. All rights reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS. All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 442 matching lines @@
 // Offsets into YuvConstants structure
 #define KUVTOB   0
 #define KUVTOG   32
 #define KUVTOR   64
 #define KUVBIASB 96
 #define KUVBIASG 128
 #define KUVBIASR 160
 #define KYTORGB  192
 #endif
 
+#if defined(__aarch64__) || defined(__arm__)
 // Conversion matrix for YUV to RGB
-extern const struct YuvConstants kYuvI601Constants;  // BT.601
-extern const struct YuvConstants kYuvJPEGConstants;  // JPeg color space
-extern const struct YuvConstants kYuvH709Constants;  // BT.709
+extern const struct YuvConstants SIMD_ALIGNED(kYuvI601Constants);  // BT.601

[skal, 2016/08/30 05:03:14]

why is there two difference macros (SIMD_ALIGNED / SIMD_ALIGNED32) ? Why not
just one?

Because, looking at the code, it seems that:
  * SIMD_ALIGNED32 is never used for aarch64 / arm, and
  * SIMD_ALIGNED is never used for x86

With just one macro, you wouldn't need these ifdefs here.

[fbarchard1, 2016/08/30 17:52:59]

Done.

+extern const struct YuvConstants SIMD_ALIGNED(kYuvJPEGConstants);  // JPeg
+extern const struct YuvConstants SIMD_ALIGNED(kYuvH709Constants);  // BT.709
 
 // Conversion matrix for YVU to BGR
-extern const struct YuvConstants kYvuI601Constants;  // BT.601
-extern const struct YuvConstants kYvuJPEGConstants;  // JPeg color space
-extern const struct YuvConstants kYvuH709Constants;  // BT.709
+extern const struct YuvConstants SIMD_ALIGNED(kYvuI601Constants);  // BT.601
+extern const struct YuvConstants SIMD_ALIGNED(kYvuJPEGConstants);  // JPeg
+extern const struct YuvConstants SIMD_ALIGNED(kYvuH709Constants);  // BT.709
+#else  // intel etc.
+// Conversion matrix for YUV to RGB
+extern const struct YuvConstants SIMD_ALIGNED32(kYuvI601Constants);  // BT.601
+extern const struct YuvConstants SIMD_ALIGNED32(kYuvJPEGConstants);  // JPeg
+extern const struct YuvConstants SIMD_ALIGNED32(kYuvH709Constants);  // BT.709
+
+// Conversion matrix for YVU to BGR
+extern const struct YuvConstants SIMD_ALIGNED32(kYvuI601Constants);  // BT.601
+extern const struct YuvConstants SIMD_ALIGNED32(kYvuJPEGConstants);  // JPeg
+extern const struct YuvConstants SIMD_ALIGNED32(kYvuH709Constants);  // BT.709
+#endif
 
 #if defined(__APPLE__) || defined(__x86_64__) || defined(__llvm__)
 #define OMITFP
 #else
 #define OMITFP __attribute__((optimize("omit-frame-pointer")))
 #endif
 
 // NaCL macros for GCC x86 and x64.
 #if defined(__native_client__)
 #define LABELALIGN ".p2align 5\n"
@@ skipping 1448 matching lines @@
 void ARGBLumaColorTableRow_SSSE3(const uint8* src_argb, uint8* dst_argb,
                                  int width,
                                  const uint8* luma, uint32 lumacoeff);
 
 #ifdef __cplusplus
 }  // extern "C"
 }  // namespace libyuv
 #endif
 
 #endif  // INCLUDE_LIBYUV_ROW_H_  NOLINT