Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Side by Side Diff: src/hydrogen-instructions.h

Issue 22915007: Clear next map word when folding allocations into js arrays. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/hydrogen.cc ('k') | src/hydrogen-instructions.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 5087 matching lines...) Expand 10 before | Expand all | Expand 10 after
5098 } 5098 }
5099 5099
5100 void MakeDoubleAligned() { 5100 void MakeDoubleAligned() {
5101 flags_ = static_cast<HAllocate::Flags>(flags_ | ALLOCATE_DOUBLE_ALIGNED); 5101 flags_ = static_cast<HAllocate::Flags>(flags_ | ALLOCATE_DOUBLE_ALIGNED);
5102 } 5102 }
5103 5103
5104 void UpdateSize(HValue* size) { 5104 void UpdateSize(HValue* size) {
5105 SetOperandAt(1, size); 5105 SetOperandAt(1, size);
5106 } 5106 }
5107 5107
5108 void ClearNextMapWord(int offset);
Michael Starzinger 2013/08/27 14:03:28 nit: Should be private.
Hannes Payer (out of office) 2013/08/27 14:13:02 Done.
5109
5108 virtual void HandleSideEffectDominator(GVNFlag side_effect, 5110 virtual void HandleSideEffectDominator(GVNFlag side_effect,
5109 HValue* dominator) V8_OVERRIDE; 5111 HValue* dominator) V8_OVERRIDE;
5110 5112
5111 virtual void PrintDataTo(StringStream* stream) V8_OVERRIDE; 5113 virtual void PrintDataTo(StringStream* stream) V8_OVERRIDE;
5112 5114
5113 DECLARE_CONCRETE_INSTRUCTION(Allocate) 5115 DECLARE_CONCRETE_INSTRUCTION(Allocate)
5114 5116
5115 private: 5117 private:
5116 enum Flags { 5118 enum Flags {
5117 ALLOCATE_IN_NEW_SPACE = 1 << 0, 5119 ALLOCATE_IN_NEW_SPACE = 1 << 0,
(...skipping 16 matching lines...) Expand all
5134 SetGVNFlag(kChangesNewSpacePromotion); 5136 SetGVNFlag(kChangesNewSpacePromotion);
5135 SetGVNFlag(kDependsOnNewSpacePromotion); 5137 SetGVNFlag(kDependsOnNewSpacePromotion);
5136 flags_ = pretenure_flag == TENURED 5138 flags_ = pretenure_flag == TENURED
5137 ? (Heap::TargetSpaceId(instance_type) == OLD_POINTER_SPACE 5139 ? (Heap::TargetSpaceId(instance_type) == OLD_POINTER_SPACE
5138 ? ALLOCATE_IN_OLD_POINTER_SPACE : ALLOCATE_IN_OLD_DATA_SPACE) 5140 ? ALLOCATE_IN_OLD_POINTER_SPACE : ALLOCATE_IN_OLD_DATA_SPACE)
5139 : ALLOCATE_IN_NEW_SPACE; 5141 : ALLOCATE_IN_NEW_SPACE;
5140 if (instance_type == FIXED_DOUBLE_ARRAY_TYPE) { 5142 if (instance_type == FIXED_DOUBLE_ARRAY_TYPE) {
5141 flags_ = static_cast<HAllocate::Flags>(flags_ | 5143 flags_ = static_cast<HAllocate::Flags>(flags_ |
5142 ALLOCATE_DOUBLE_ALIGNED); 5144 ALLOCATE_DOUBLE_ALIGNED);
5143 } 5145 }
5146 clear_next_map_word_ = AllocationSite::CanTrack(instance_type);
5144 } 5147 }
5145 5148
5146 Flags flags_; 5149 Flags flags_;
5147 Handle<Map> known_initial_map_; 5150 Handle<Map> known_initial_map_;
5151 bool clear_next_map_word_;
5148 }; 5152 };
5149 5153
5150 5154
5151 class HInnerAllocatedObject V8_FINAL : public HTemplateInstruction<1> { 5155 class HInnerAllocatedObject V8_FINAL : public HTemplateInstruction<1> {
5152 public: 5156 public:
5153 static HInnerAllocatedObject* New(Zone* zone, 5157 static HInnerAllocatedObject* New(Zone* zone,
5154 HValue* context, 5158 HValue* context,
5155 HValue* value, 5159 HValue* value,
5156 int offset, 5160 int offset,
5157 HType type = HType::Tagged()) { 5161 HType type = HType::Tagged()) {
(...skipping 1635 matching lines...) Expand 10 before | Expand all | Expand 10 after
6793 virtual bool IsDeletable() const V8_OVERRIDE { return true; } 6797 virtual bool IsDeletable() const V8_OVERRIDE { return true; }
6794 }; 6798 };
6795 6799
6796 6800
6797 #undef DECLARE_INSTRUCTION 6801 #undef DECLARE_INSTRUCTION
6798 #undef DECLARE_CONCRETE_INSTRUCTION 6802 #undef DECLARE_CONCRETE_INSTRUCTION
6799 6803
6800 } } // namespace v8::internal 6804 } } // namespace v8::internal
6801 6805
6802 #endif // V8_HYDROGEN_INSTRUCTIONS_H_ 6806 #endif // V8_HYDROGEN_INSTRUCTIONS_H_
OLDNEW
« no previous file with comments | « src/hydrogen.cc ('k') | src/hydrogen-instructions.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698