Issue 22915005: MessageEvent constructor should accept a MessagePort as source

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22915005: MessageEvent constructor should accept a MessagePort as source (Closed)

Created:
7 years, 4 months ago by do-not-use

Modified:
7 years, 4 months ago

Reviewers:
abarth-chromium

CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

MessageEvent constructor should accept a MessagePort as source MessageEvent constructor should accept a MessagePort as source in the MessageEventInit dictionary. Previously, it was only accepting a Window object as source. The specification was updated recently to address this issue: https://www.w3.org/Bugs/Public/show_bug.cgi?id=23011 http://html5.org/tools/web-apps-tracker?from=8147&to=8148 R=abarth BUG=276474 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156420

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -5 lines)			Patch
M	LayoutTests/fast/events/constructors/message-event-constructor.html	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	LayoutTests/fast/events/constructors/message-event-constructor-expected.txt	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/dom/MessageEvent.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/dom/MessageEvent.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (0 generated)

do-not-use

This is a follow up to https://src.chromium.org/viewvc/blink?revision=156385&view=revision now that the specification was fixed.

7 years, 4 months ago (2013-08-20 18:09:18 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/22915005/1

7 years, 4 months ago (2013-08-20 19:29:19 UTC) #4

Message was sent while issue was closed.

Change committed as 156420