Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 2291433003: [turbofan] Nuke the funny typing rule for JSTypedArray constants. (Closed)

Created:
4 years, 3 months ago by Benedikt Meurer
Modified:
4 years, 3 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Nuke the funny typing rule for JSTypedArray constants. R=jarin@chromium.org BUG=v8:5267 Committed: https://crrev.com/ead8f658cdf7784852b288a29f47947766472110 Cr-Commit-Position: refs/heads/master@{#38966}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -9 lines) Patch
M src/compiler/typer.cc View 1 chunk +0 lines, -9 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (6 generated)
Benedikt Meurer
4 years, 3 months ago (2016-08-29 06:37:16 UTC) #1
Jarin
lgtm
4 years, 3 months ago (2016-08-29 06:40:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2291433003/1
4 years, 3 months ago (2016-08-29 07:07:40 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-29 07:09:39 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-08-29 07:10:00 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ead8f658cdf7784852b288a29f47947766472110
Cr-Commit-Position: refs/heads/master@{#38966}

Powered by Google App Engine
This is Rietveld 408576698