Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1061)

Unified Diff: runtime/vm/flow_graph_allocator.cc

Issue 229143002: Restore WritableRegister input LiveRange shape (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_allocator.cc
diff --git a/runtime/vm/flow_graph_allocator.cc b/runtime/vm/flow_graph_allocator.cc
index f17badf3b0e7fb7e43eabb983c87fb88eeb0ce59..00e12a473937cbb0b701a189aa750cb2a7fc0f27 100644
--- a/runtime/vm/flow_graph_allocator.cc
+++ b/runtime/vm/flow_graph_allocator.cc
@@ -913,22 +913,22 @@ void FlowGraphAllocator::ProcessOneInput(BlockEntryInstr* block,
// Writable unallocated input. Expected shape of
// live ranges:
//
- // j' i i'
+ // i i'
// value --*
- // temp [------)
- MoveOperands* move = AddMoveAt(pos - 1,
+ // temp [--)
+ MoveOperands* move = AddMoveAt(pos,
Location::RequiresRegister(),
Location::PrefersRegister());
// Add uses to the live range of the input.
- range->AddUseInterval(block->start_pos(), pos - 1);
- range->AddUse(pos - 1, move->src_slot());
+ range->AddUseInterval(block->start_pos(), pos);
+ range->AddUse(pos, move->src_slot());
// Create live range for the temporary.
LiveRange* temp = MakeLiveRangeForTemporary();
- temp->AddUseInterval(pos - 1, pos + 1);
- temp->AddHintedUse(pos - 1, in_ref, move->src_slot());
- temp->AddUse(pos + 1, move->dest_slot());
+ temp->AddUseInterval(pos, pos + 1);
+ temp->AddHintedUse(pos, in_ref, move->src_slot());
+ temp->AddUse(pos, move->dest_slot());
*in_ref = Location::RequiresRegister();
CompleteRange(temp, RegisterKindFromPolicy(*in_ref));
} else {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698