Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 2291423002: Remove debugPosition() functions. (Closed)

Created:
4 years, 3 months ago by tkent
Modified:
4 years, 3 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove debugPosition() functions. This CL remove debugPosition() functions for Position, VisiblePosition, and VisibleSelection. showTree*() functions are usually enough. This CL doesn't affect production. Committed: https://crrev.com/3166b5e20f02c73995a1b4de28a4817678b1482d Cr-Commit-Position: refs/heads/master@{#415557}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -62 lines) Patch
M third_party/WebKit/Source/core/editing/Position.h View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/Position.cpp View 1 chunk +0 lines, -26 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisiblePosition.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/VisiblePosition.cpp View 1 chunk +0 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleSelection.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleSelection.cpp View 1 chunk +0 lines, -22 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
tkent
yosin@, would you review this please?
4 years, 3 months ago (2016-08-31 01:45:29 UTC) #4
yosin_UTC9
lgtm Thanks for cleanup!
4 years, 3 months ago (2016-08-31 01:52:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2291423002/1
4 years, 3 months ago (2016-08-31 02:29:16 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-31 04:30:25 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 04:33:46 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3166b5e20f02c73995a1b4de28a4817678b1482d
Cr-Commit-Position: refs/heads/master@{#415557}

Powered by Google App Engine
This is Rietveld 408576698