Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2291413002: Add testing config for OverlayFullscreenVideo. (Closed)

Created:
4 years, 3 months ago by sandersd (OOO until July 31)
Modified:
4 years, 3 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add testing config for OverlayFullscreenVideo. BUG=642571 Committed: https://crrev.com/99fce27763b037227011e357502b1c700477d153 Cr-Commit-Position: refs/heads/master@{#415825}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M testing/variations/fieldtrial_testing_config_android.json View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
sandersd (OOO until July 31)
This follows after https://codereview.chromium.org/2297973002/, which adds the feature in question.
4 years, 3 months ago (2016-08-31 00:29:11 UTC) #2
Alexei Svitkine (slow)
lgtm
4 years, 3 months ago (2016-08-31 15:46:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2291413002/1
4 years, 3 months ago (2016-09-01 00:16:47 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-01 00:59:40 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/99fce27763b037227011e357502b1c700477d153 Cr-Commit-Position: refs/heads/master@{#415825}
4 years, 3 months ago (2016-09-01 01:01:46 UTC) #8
sandersd (OOO until July 31)
4 years, 3 months ago (2016-09-02 23:01:22 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2306233002/ by sandersd@chromium.org.

The reason for reverting is: Turns out we shouldn't do this for optimization
experiments, since we don't actually want this enabled for all dev builds..

Powered by Google App Engine
This is Rietveld 408576698