Issue 22914034: Delete dead FloatingPointHelper functions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22914034: Delete dead FloatingPointHelper functions (Closed)

Created:
7 years, 4 months ago by Jakob Kummerow

Modified:
7 years, 4 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Delete dead FloatingPointHelper functions R=svenpanne@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=16290

Patch Set 1 #

Total comments: 1

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -94 lines)			Patch
	M	src/ia32/code-stubs-ia32.cc	View		2 chunks	+0 lines, -32 lines	0 comments	Download
	M	src/x64/code-stubs-x64.cc	View		4 chunks	+0 lines, -62 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

PTAL. https://codereview.chromium.org/22914034/diff/1/src/x64/code-stubs-x64.cc File src/x64/code-stubs-x64.cc (left): https://codereview.chromium.org/22914034/diff/1/src/x64/code-stubs-x64.cc#oldcode1572 src/x64/code-stubs-x64.cc:1572: __ call(stub1.GetCode(masm->isolate()), RelocInfo::CODE_TARGET); This was actually a bug: ...

7 years, 4 months ago (2013-08-23 08:31:48 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 manually as r16290.

Expand Messages | Collapse Messages