Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Unified Diff: pkg/barback/lib/src/asset_cascade.dart

Issue 22914031: Support actually removing phases in barback. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/barback/lib/src/phase.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/barback/lib/src/asset_cascade.dart
diff --git a/pkg/barback/lib/src/asset_cascade.dart b/pkg/barback/lib/src/asset_cascade.dart
index e8e9355fe17d00198b628b29d6aa3014d1e79618..078c510c530322a16c6e59808f4a4922525c6911 100644
--- a/pkg/barback/lib/src/asset_cascade.dart
+++ b/pkg/barback/lib/src/asset_cascade.dart
@@ -186,12 +186,11 @@ class AssetCascade {
_addPhase(_phases.last.addPhase(transformers[i]));
}
- if (transformers.length < _phases.length) {
- for (var i = transformers.length; i < _phases.length; i++) {
- // TODO(nweiz): actually remove phases rather than emptying them of
- // transformers.
- _phases[i].updateTransformers([]);
- }
+ if (transformers.length == 0) {
+ _phases.last.updateTransformers([]);
+ } else if (transformers.length < _phases.length) {
+ _phases[transformers.length - 1].removeFollowing();
+ _phases.removeRange(transformers.length, _phases.length);
}
}
« no previous file with comments | « no previous file | pkg/barback/lib/src/phase.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698