Issue 2291403002: [Android] Remove close button on download manager's toolbar on tablet

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2291403002: [Android] Remove close button on download manager's toolbar on tablet (Closed)

Created:
4 years, 3 months ago by Ian Wen

Modified:
4 years, 3 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2840

Project:
chromium

Visibility:
Public.

[Android] Remove close button on download manager's toolbar on tablet On tablet this button does nothing. We should remove it. BUG=638111 Review-Url: https://codereview.chromium.org/2292303003 Cr-Commit-Position: refs/heads/master@{#415493} (cherry picked from commit 9b97afa26f5ac9b108b504db1f7b49bd869d8e05) Committed: https://chromium.googlesource.com/chromium/src/+/4cce8c535546081c562751a1fe806a9b0e2e18e5

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadManagerToolbar.java	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (1 generated)

Ian Wen

4 years, 3 months ago (2016-08-31 00:01:57 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
4cce8c535546081c562751a1fe806a9b0e2e18e5.