Chromium Code Reviews| Index: public/platform/WebSocketChannelHandle.h |
| diff --git a/public/platform/WebDeviceOrientationData.h b/public/platform/WebSocketChannelHandle.h |
| similarity index 67% |
| copy from public/platform/WebDeviceOrientationData.h |
| copy to public/platform/WebSocketChannelHandle.h |
| index 072dd09b867550bf4ba03cfc4e67f7abb3bc7405..bf087473b94a56c892859549983668e8ed9bcbe1 100644 |
| --- a/public/platform/WebDeviceOrientationData.h |
| +++ b/public/platform/WebSocketChannelHandle.h |
| @@ -28,44 +28,37 @@ |
| * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. |
| */ |
| -#ifndef WebDeviceOrientationData_h |
| -#define WebDeviceOrientationData_h |
| +#ifndef WebSocketChannelHandle_h |
| +#define WebSocketChannelHandle_h |
| #include "WebCommon.h" |
| - |
| -#if WEBKIT_IMPLEMENTATION |
| -#include "wtf/Assertions.h" |
| -#endif |
| +#include "WebVector.h" |
| namespace WebKit { |
| -#pragma pack(push, 1) |
| +class WebData; |
| +class WebSocketChannelHandleClient; |
| +class WebString; |
| +class WebURL; |
| -class WebDeviceOrientationData { |
| +// FIXME: This class will replace WebSocketStreamHandle. |
| +class WebSocketChannelHandle { |
| public: |
| - WEBKIT_EXPORT WebDeviceOrientationData(); |
| - ~WebDeviceOrientationData() { } |
| - |
| - double alpha; |
| - double beta; |
| - double gamma; |
| - |
| - bool hasAlpha : 1; |
| - bool hasBeta : 1; |
| - bool hasGamma : 1; |
| + enum MessageType { |
| + MessageTypeText, |
| + MessageTypeBinary, |
| + MessageTypeContinuation, |
| + }; |
| - bool absolute : 1; |
| - bool hasAbsolute : 1; |
| + virtual ~WebSocketChannelHandle() { } |
| - bool allAvailableSensorsAreActive : 1; |
| + virtual void connect(const WebURL& /* url */, const WebVector<WebString>& protocols, const WebString& origin, WebSocketChannelHandleClient*) = 0; |
|
abarth-chromium
2013/08/22 19:39:07
No need for /* */ around argument names. Just put
yhirano
2013/08/23 01:35:13
check-webkit-style complains as:
The parameter n
|
| + virtual void send(const char* data, size_t /* size */, MessageType, bool fin) = 0; |
| + virtual void flowControl(int64_t quota); |
| + virtual void close(unsigned short code, const WebString& reason) = 0; |
| }; |
| -#if WEBKIT_IMPLEMENTATION |
| -COMPILE_ASSERT(sizeof(WebDeviceOrientationData) == (3 * sizeof(double) + 1 * sizeof(char)), WebDeviceOrientationData_has_wrong_size); |
| -#endif |
| - |
| -#pragma pack(pop) |
| - |
| } // namespace WebKit |
| -#endif // WebDeviceOrientationData_h |
| +#endif // WebSocketChannelHandle_h |
| + |