Logged information from BufferedDataSource including

content/renderer/media/buffered_data_source.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/media/buffered_data_source.h"
 
 #include "base/bind.h"
 #include "base/callback_helpers.h"
 #include "base/message_loop/message_loop_proxy.h"
 #include "media/base/media_log.h"
@@ skipping 352 matching lines @@
 
   // All responses must be successful. Resources that are assumed to be fully
   // buffered must have a known content length.
   bool success = status == BufferedResourceLoader::kOk &&
       (!assume_fully_buffered_ ||
        loader_->instance_size() != kPositionNotSpecified);
 
   if (success) {
     total_bytes_ = loader_->instance_size();
     streaming_ = !assume_fully_buffered_ &&
         (total_bytes_ == kPositionNotSpecified || !loader_->range_supported());

[scherkus (not reviewing), 2013/08/22 01:32:58]

I'd actually have total bytes logged in this class and *not* in FFmpegDemuxer
(why? because BDS knows much more about the total bytes value)

can you add a log line to the success block below and remove the one from
FFmpegDemuxer?

[Ty Overby, 2013/09/09 22:40:13]

Do you still want this done?

[scherkus (not reviewing), 2013/09/09 22:42:58]

Ah so I'm *not* crazy! I swore I saw you add MediaLog code to BDS but couldn't
find it :)

Yeah, if you plan on landing this can you remove the total_bytes from
FFmpegDemuxer?

[Ty Overby, 2013/09/09 22:52:32]

Haha, yeah, I do plan on landing this.

Done.

   } else {
     loader_->Stop();
   }
 
   // TODO(scherkus): we shouldn't have to lock to signal host(), see
   // http://crbug.com/113712 for details.
   base::AutoLock auto_lock(lock_);
   if (stop_signal_received_)
     return;
 
-  if (success)
+  if (success) {
     UpdateHostState_Locked();
+    media_log_->SetBooleanProperty("single_origin", loader_->HasSingleOrigin());
+    media_log_->SetBooleanProperty("pass_cors_access_check",

[scherkus (not reviewing), 2013/08/22 01:32:59]

nit: s/pass/passed/

[Ty Overby, 2013/09/09 22:40:13]

Done.

+                                   loader_->DidPassCORSAccessCheck());
+    // HTTP range header

[scherkus (not reviewing), 2013/08/22 01:32:59]

nit: remove this comment

[Ty Overby, 2013/09/09 22:40:13]

Done.

+    media_log_->SetBooleanProperty("range_supported",
+                                   loader_->range_supported());
+  }
 
   base::ResetAndReturn(&init_cb_).Run(success);
 }
 
 void BufferedDataSource::PartialReadStartCallback(
     BufferedResourceLoader::Status status) {
   DCHECK(render_loop_->BelongsToCurrentThread());
   DCHECK(loader_.get());
 
   if (status == BufferedResourceLoader::kOk) {
@@ skipping 26 matching lines @@
     return;
 
   if (status != BufferedResourceLoader::kOk) {
     // Stop the resource load if it failed.
     loader_->Stop();
 
     if (status == BufferedResourceLoader::kCacheMiss &&
         read_op_->retries() < kNumCacheMissRetries) {
       read_op_->IncrementRetries();
 
+      media_log_->SetIntegerProperty("read_retries", read_op_->retries());

[scherkus (not reviewing), 2013/08/22 01:32:59]

for now you can remove it ... it's a lower priority one vs. other ones

(main reason being, the other logs are captured and logged on the initial
connection, but this one can be set anytime we seek and force a new HTTP
connection ... adding per-connection logging should be tackled as a separate
problem)

[Ty Overby, 2013/09/09 22:40:13]

Done.

+
       // Recreate a loader starting from where we last left off until the
       // end of the resource.
       loader_.reset(CreateResourceLoader(
           read_op_->position(), kPositionNotSpecified));
       loader_->Start(
           base::Bind(&BufferedDataSource::PartialReadStartCallback, weak_this_),
           base::Bind(&BufferedDataSource::LoadingStateChangedCallback,
                      weak_this_),
           base::Bind(&BufferedDataSource::ProgressCallback, weak_this_),
           frame_);
@@ skipping 87 matching lines @@
   if (total_bytes_ == kPositionNotSpecified)
     return;
 
   host()->SetTotalBytes(total_bytes_);
 
   if (assume_fully_buffered_)
     host()->AddBufferedByteRange(0, total_bytes_);
 }
 
 }  // namespace content