Issue 22914014: Add more control over sync for Chromium testshell.

Issue 22914014: Add more control over sync for Chromium testshell. (Closed)

Created:
7 years, 4 months ago by nyquist

Modified:
7 years, 3 months ago

Reviewers:
shashi, Yaron, Nicolas Zea

CC:
chromium-reviews, tim+watch_chromium.org, rsimha+watch_chromium.org, haitaol+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add more control over sync for Chromium testshell. * Adds more functionality to the Chromium testshell SyncController. * Enables GCM for sync. * Upstream sync test framework and chrome://sync tests. * Adds auto-login to Chromium testshell. BUG=272584 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221234

Patch Set 1 #

Patch Set 2 : Fixed manifest for provider and GCM #

Patch Set 3 : Upstream sync tests #

Patch Set 4 : Flip system service exception #

Patch Set 5 : Fixed findbugs #

Total comments: 12

Patch Set 6 : Addressed most comments #

Patch Set 7 : Fixed manifest #

Patch Set 8 : fixed browser startup #

Total comments: 6

Patch Set 9 : Updated from CL this depends on. #

Total comments: 2

Patch Set 10 : Start using @HostDrivenTest annotation #

Patch Set 11 : Added comments for ProfileSyncServiceAndroid #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+806 lines, -24 lines)			Patch
A	chrome/android/host_driven_tests/SyncTest.py	View	1 2 3 4 5 6 7 8	1 chunk	+55 lines, -0 lines	0 comments	Download
M	chrome/android/java/src/org/chromium/chrome/browser/identity/UuidBasedUniqueIdentificationGenerator.java	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/android/java/src/org/chromium/chrome/browser/sync/ProfileSyncService.java	View	1 2	2 chunks	+11 lines, -0 lines	0 comments	Download
A	chrome/android/javatests/src/org/chromium/chrome/browser/sync/SyncTest.java	View	1 2 3 4 5 6 7 8 9	1 chunk	+188 lines, -0 lines	0 comments	Download
M	chrome/android/testshell/java/AndroidManifest.xml	View	1 2 3 4 5 6	4 chunks	+75 lines, -19 lines	0 comments	Download
M	chrome/android/testshell/java/src/org/chromium/chrome/testshell/ChromiumTestShellActivity.java	View		3 chunks	+9 lines, -0 lines	0 comments	Download
M	chrome/android/testshell/java/src/org/chromium/chrome/testshell/sync/SyncController.java	View	1 2 3 4 5	2 chunks	+102 lines, -5 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service_android.h	View	1 2 3 4 5 6 7 8 9 10	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service_android.cc	View	1 2 3 4 5 6 7 8 9 10	1 chunk	+9 lines, -0 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 2 3 4 5 6 7 8 9	1 chunk	+2 lines, -0 lines	0 comments	Download
A	chrome/test/android/DEPS	View	1 2	1 chunk	+5 lines, -0 lines	0 comments	Download
A	chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/sync/SyncTestUtil.java	View	1 2 3 4	1 chunk	+345 lines, -0 lines	0 comments	Download

Messages

Total messages: 12 (0 generated)

Expand Messages | Collapse Messages

Yaron

https://codereview.chromium.org/22914014/diff/19001/chrome/android/javatests/src/org/chromium/chrome/browser/sync/SyncTest.java File chrome/android/javatests/src/org/chromium/chrome/browser/sync/SyncTest.java (right): https://codereview.chromium.org/22914014/diff/19001/chrome/android/javatests/src/org/chromium/chrome/browser/sync/SyncTest.java#newcode57 chrome/android/javatests/src/org/chromium/chrome/browser/sync/SyncTest.java:57: clearAppData(); Should this be in ChromiumTestShellTestBase? https://codereview.chromium.org/22914014/diff/19001/chrome/android/javatests/src/org/chromium/chrome/browser/sync/SyncTest.java#newcode78 chrome/android/javatests/src/org/chromium/chrome/browser/sync/SyncTest.java:78: private ...

7 years, 3 months ago (2013-08-27 18:19:23 UTC) #2

nyquist

Addressed all comments. shashishekhar: PTAL https://codereview.chromium.org/22914014/diff/19001/chrome/android/javatests/src/org/chromium/chrome/browser/sync/SyncTest.java File chrome/android/javatests/src/org/chromium/chrome/browser/sync/SyncTest.java (right): https://codereview.chromium.org/22914014/diff/19001/chrome/android/javatests/src/org/chromium/chrome/browser/sync/SyncTest.java#newcode57 chrome/android/javatests/src/org/chromium/chrome/browser/sync/SyncTest.java:57: clearAppData(); On 2013/08/27 18:19:23, ...

7 years, 3 months ago (2013-08-30 00:55:43 UTC) #3

shashi

https://codereview.chromium.org/22914014/diff/36001/chrome/android/javatests/src/org/chromium/chrome/browser/sync/SyncTest.java File chrome/android/javatests/src/org/chromium/chrome/browser/sync/SyncTest.java (right): https://codereview.chromium.org/22914014/diff/36001/chrome/android/javatests/src/org/chromium/chrome/browser/sync/SyncTest.java#newcode89 chrome/android/javatests/src/org/chromium/chrome/browser/sync/SyncTest.java:89: @DisabledTest This is a bit non-intuitive and I had ...

7 years, 3 months ago (2013-08-30 05:30:31 UTC) #4

nyquist

7 years, 3 months ago (2013-08-30 05:45:34 UTC) #5

https://codereview.chromium.org/22914014/diff/36001/chrome/android/javatests/...
File chrome/android/javatests/src/org/chromium/chrome/browser/sync/SyncTest.java
(right):

https://codereview.chromium.org/22914014/diff/36001/chrome/android/javatests/...
chrome/android/javatests/src/org/chromium/chrome/browser/sync/SyncTest.java:89:
@DisabledTest
On 2013/08/30 05:30:31, shashi wrote:
> This is a bit non-intuitive and I had the same question as Yaron's previous
> comment.
> Perhaps we can file a bug for testing team to add a new annotation,
> @PythonDrivenTest so that the script that uses proguard to list tests does not
> list python driven tests.
> 
> wdyt?

Sounds good. Filed https://code.google.com/p/chromium/issues/detail?id=282102

https://codereview.chromium.org/22914014/diff/36001/chrome/android/testshell/...
File chrome/android/testshell/java/AndroidManifest.xml (right):

https://codereview.chromium.org/22914014/diff/36001/chrome/android/testshell/...
chrome/android/testshell/java/AndroidManifest.xml:18: <uses-permission
android:name="android.permission.GET_ACCOUNTS"/>
On 2013/08/30 05:30:31, shashi wrote:
> Why all these permissions?
> 
> Can we remove CAMERA, ACCESS_COARSE_LOCATION, ACCESS_NETWORK_STATE,
> RECORD_AUDIO, MODIFY_AUDIO_SETTINGS, VIBRATE, etc.

I would think they are for WebRTC, Geolocation, network change provider things,
WebRTC, media player, Vibrate API, etc. accordingly.

I just moved these around in this CL. I would like to not make any changes to
them in this CL, in case it breaks something.

https://codereview.chromium.org/22914014/diff/36001/chrome/android/testshell/...
chrome/android/testshell/java/AndroidManifest.xml:171:
android:authorities="org.chromium.chrome.testshell"
On 2013/08/30 05:30:31, shashi wrote:
> Why need this provider?

The provider is needed to get the contract with Android working regarding having
a sync adapter.

There are several parts needed: A definition of the authority (package), the
sync adapter XML file, a syncadapter service, the syncadapter itself, and a
provider. Without a provider, the syncing does not work correctly.

Nicolas Zea

sync LGTM https://codereview.chromium.org/22914014/diff/29001/chrome/browser/sync/profile_sync_service_android.h File chrome/browser/sync/profile_sync_service_android.h (right): https://codereview.chromium.org/22914014/diff/29001/chrome/browser/sync/profile_sync_service_android.h#newcode196 chrome/browser/sync/profile_sync_service_android.h:196: jlong GetLastSyncedTimeForTest(JNIEnv* env, jobject obj); add comment?

7 years, 3 months ago (2013-08-30 22:32:18 UTC) #9

nyquist

Addressed all comments, and all CLs this depends on has landed. https://codereview.chromium.org/22914014/diff/29001/chrome/browser/sync/profile_sync_service_android.h File chrome/browser/sync/profile_sync_service_android.h (right): ...

7 years, 3 months ago (2013-09-04 15:26:36 UTC) #10

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nyquist@chromium.org/22914014/45001

7 years, 3 months ago (2013-09-04 16:31:52 UTC) #11

Message was sent while issue was closed.

Change committed as 221234

Expand Messages | Collapse Messages