ios/web/public/test/response_providers/html_response_provider_impl.h - Issue 2291393003: Add capability to simple http server to bound Set-Cookie to URLs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/web/public/test/response_providers/html_response_provider_impl.h

Issue 2291393003: Add capability to simple http server to bound Set-Cookie to URLs. (Closed)

Patch Set: Addressed comments from Peter Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ios/web/public/test/response_providers/html_response_provider.mm ('k') | ios/web/public/test/response_providers/html_response_provider_impl.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/web/public/test/response_providers/html_response_provider_impl.h

diff --git a/ios/web/public/test/response_providers/html_response_provider_impl.h b/ios/web/public/test/response_providers/html_response_provider_impl.h

index 16991b8a9be95dc13a9890b9649c88b3d733f58e..d9214b5de5796a9923254d7c2554bb1c4f293038 100644

--- a/ios/web/public/test/response_providers/html_response_provider_impl.h

+++ b/ios/web/public/test/response_providers/html_response_provider_impl.h

@@ -39,11 +39,11 @@ class HtmlResponseProviderImpl {

// response to a URL based on the mapping present in |responses|.

explicit HtmlResponseProviderImpl(

const std::map<GURL, std::string>& responses);

- // Constructs an HtmlResponseProviderImpl that generates a simple string

- // response to a URL based on the mapping present in |responses| and |cookie|.

+ // Constructs an HtmlResponseProvider that generates a simple string response

+ // to a URL with set cookie in the headers based on the mapping present in

+ // |responses|.

explicit HtmlResponseProviderImpl(

- const std::map<GURL, std::string>& responses,

- const std::string& cookie);

+ const std::map<GURL, std::pair<std::string, std::string>>& responses);

// Constructs an HtmlResponseProviderImpl that generates a response to a URL

// based on the mapping present in |responses|.

explicit HtmlResponseProviderImpl(const std::map<GURL, Response>& responses);