Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(789)

Issue 2291333002: [DevTools] Fix inspector-protocol/runtime/runtime-execution-contexts-events.html (Closed)

Created:
4 years, 3 months ago by kozy
Modified:
4 years, 3 months ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Fix inspector-protocol/runtime/runtime-execution-contexts-events.html It's too early to navigate frame when we get executeContextCreated. BUG=596940 R=lushnikov@chromium.org Committed: https://crrev.com/0d0728472faa159620d4d364881ccfe8650bd0f0 Cr-Commit-Position: refs/heads/master@{#415423}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-execution-contexts-events.html View 3 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
kozy
Andrey, please take a look
4 years, 3 months ago (2016-08-30 19:24:14 UTC) #1
lushnikov
lgtm
4 years, 3 months ago (2016-08-30 20:23:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2291333002/1
4 years, 3 months ago (2016-08-30 20:27:00 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-30 21:03:55 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 21:05:44 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0d0728472faa159620d4d364881ccfe8650bd0f0
Cr-Commit-Position: refs/heads/master@{#415423}

Powered by Google App Engine
This is Rietveld 408576698