Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1127)

Issue 229133003: Disable SK_GAMMA_SRGB on android builds. (Closed)

Created:
6 years, 8 months ago by djsollen
Modified:
6 years, 8 months ago
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : correct android gamma #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M gyp/common_conditions.gypi View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
djsollen
This will break nearly all of the Android GM's so I'll need to rebase nearly ...
6 years, 8 months ago (2014-04-10 16:36:48 UTC) #1
scroggo
On 2014/04/10 16:36:48, djsollen wrote: > This will break nearly all of the Android GM's ...
6 years, 8 months ago (2014-04-10 16:44:19 UTC) #2
bungeman-skia
lgtm
6 years, 8 months ago (2014-04-10 16:58:54 UTC) #3
scroggo
lgtm https://codereview.chromium.org/229133003/diff/1/gyp/common_conditions.gypi File gyp/common_conditions.gypi (right): https://codereview.chromium.org/229133003/diff/1/gyp/common_conditions.gypi#newcode600 gyp/common_conditions.gypi:600: [ 'skia_os != "android"', { On 2014/04/10 16:44:19, ...
6 years, 8 months ago (2014-04-10 16:59:37 UTC) #4
djsollen
6 years, 8 months ago (2014-04-11 13:09:25 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r14148.

Powered by Google App Engine
This is Rietveld 408576698