Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 2291293003: Fix evaluating in async/sync*/async* methods. (Closed)

Created:
4 years, 3 months ago by rmacnak
Modified:
4 years, 3 months ago
Reviewers:
hausner
CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix evaluating in async/sync*/async* methods. Fixes #27167. R=hausner@google.com Committed: https://github.com/dart-lang/sdk/commit/c80b23b7ff87a6fa084a4c218d6339462467b369

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+188 lines, -2 lines) Patch
A runtime/observatory/tests/service/evaluate_in_async_activation_test.dart View 1 chunk +57 lines, -0 lines 0 comments Download
A runtime/observatory/tests/service/evaluate_in_async_star_activation_test.dart View 1 chunk +62 lines, -0 lines 0 comments Download
A runtime/observatory/tests/service/evaluate_in_sync_star_activation_test.dart View 1 chunk +62 lines, -0 lines 0 comments Download
M runtime/vm/debugger.cc View 2 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
4 years, 3 months ago (2016-08-30 20:25:48 UTC) #2
hausner
LGTM
4 years, 3 months ago (2016-08-30 20:37:57 UTC) #3
rmacnak
4 years, 3 months ago (2016-08-30 22:17:03 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c80b23b7ff87a6fa084a4c218d6339462467b369 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698