Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Unified Diff: scripts/slave/recipe_modules/goma/api.py

Issue 2291273005: Add counting the number of CPU's in goma module (Closed)
Patch Set: fix comment Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/goma/example.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipe_modules/goma/api.py
diff --git a/scripts/slave/recipe_modules/goma/api.py b/scripts/slave/recipe_modules/goma/api.py
index 97c12f3f6e200a5787d3a682631de8b9f410a1b0..c4f6117edad150678dc6afd54a9ab20b4c9cccfe 100644
--- a/scripts/slave/recipe_modules/goma/api.py
+++ b/scripts/slave/recipe_modules/goma/api.py
@@ -14,6 +14,7 @@ class GomaApi(recipe_api.RecipeApi):
self._goma_ctl_env = {}
self._cloudtail_pid = None
+ self._goma_jobs = None
@property
def service_account_json_path(self):
@@ -31,6 +32,40 @@ class GomaApi(recipe_api.RecipeApi):
assert self._goma_dir
return self.m.path.join(self._goma_dir, 'jsonstatus')
+ @property
+ def recommended_goma_jobs(self):
+ """
+ Return the recommended number of jobs for parallel build using Goma.
+
+ This function caches the _goma_jobs.
+ """
+ if self._goma_jobs:
+ return self._goma_jobs
+
+ # Use 80 for linux not to load goma backend.
+ if self.m.platform.is_linux:
+ return 80
shinyak 2016/09/07 04:45:54 Instead of using constant 80, could you limit max
tikuta 2016/09/07 04:53:08 Done.
+
+ step_result = self.m.python.inline(
+ 'calculate the number of recommended jobs',
+ """
+ import multiprocessing
+
+ try:
+ jobs = min(200, multiprocessing.cpu_count() * 10)
+ except NotImplementedError:
+ jobs = 50
+
+ print jobs
+ """,
+ stdout=self.m.raw_io.output(),
+ step_test_data=(
+ lambda: self.m.raw_io.test_api.stream_output('50\n'))
+ )
+ self._goma_jobs = int(step_result.stdout)
+
+ return self._goma_jobs
+
def ensure_goma(self, canary=False):
with self.m.step.nest('ensure_goma'):
with self.m.step.context({'infra_step': True}):
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/goma/example.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698