Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Issue 2291273003: Ntp: show footer with learn more link. (Closed)

Created:
4 years, 3 months ago by Marc Treib
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Ntp: show footer with learn more link. BUG=637257 Review-Url: https://codereview.chromium.org/2275693003 Cr-Commit-Position: refs/heads/master@{#414738} (cherry picked from commit 35978862e4fc752f742ab01d6ab0883b99cfd374) Committed: https://chromium.googlesource.com/chromium/src/+/73225c1a548b1fb20c2fedee56ea22d40809914d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+248 lines, -179 lines) Patch
A + chrome/android/java/res/layout/new_tab_page_footer.xml View 1 chunk +6 lines, -4 lines 0 comments Download
M chrome/android/java/res/layout/new_tab_page_snippets_header.xml View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/CardViewHolder.java View 2 chunks +2 lines, -0 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/Footer.java View 1 chunk +50 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java View 4 chunks +7 lines, -4 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageItem.java View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java View 3 chunks +6 lines, -7 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SectionHeaderViewHolder.java View 3 chunks +1 line, -3 lines 0 comments Download
M chrome/android/java/strings/android_chrome_strings.grd View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/android/java_sources.gni View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/ntp/snippets/ArticleSnippetsTest.java View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapterTest.java View 20 chunks +148 lines, -160 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Marc Treib
4 years, 3 months ago (2016-08-31 09:23:59 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
73225c1a548b1fb20c2fedee56ea22d40809914d.

Powered by Google App Engine
This is Rietveld 408576698