Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1456)

Unified Diff: runtime/observatory/lib/src/elements/service_view.dart

Issue 2291233002: Converted Observatory instance-view element (Closed)
Patch Set: Addressed comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/elements/service_view.dart
diff --git a/runtime/observatory/lib/src/elements/service_view.dart b/runtime/observatory/lib/src/elements/service_view.dart
index 6cd9a3e739db66ce4b6da2fec3be154c6229b677..5b42f845d6921e5c536050a2b90e9a50baabb4b0 100644
--- a/runtime/observatory/lib/src/elements/service_view.dart
+++ b/runtime/observatory/lib/src/elements/service_view.dart
@@ -52,16 +52,9 @@ class ServiceObjectViewElement extends ObservatoryElement {
element.vm = object;
return element;
default:
- if (object.isInstance ||
- object.isSentinel) { // TODO(rmacnak): Separate this out.
- InstanceViewElement element = new Element.tag('instance-view');
- element.instance = object;
- return element;
- } else {
- JsonViewElement element = new Element.tag('json-view');
- element.map = object;
- return element;
- }
+ JsonViewElement element = new Element.tag('json-view');
+ element.map = object;
+ return element;
}
}
« no previous file with comments | « runtime/observatory/lib/src/elements/sentinel_view.dart ('k') | runtime/observatory/lib/src/elements/service_view.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698