It's time to bring subprocess42 to depot_tools.

It's time to bring subprocess42 to depot_tools.

The immediate need is to properly kill git fetch and its sub-spawned
process from gclient.

R=maruel@chromium.org, hinoka@chromium.org
BUG=635641
Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/6d3c290164360907fe08784093e36314069e689f

[tandrii(chromium), 2016-08-31 01:24:37]

The CQ bit was checked by tandrii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-31 01:24:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[M-A Ruel, 2016-08-31 01:27:36]

lgtm

I hadn't done it because I didn't want to take the time to do it thoroughly. I'm
that lazy.

[commit-bot: I haz the power, 2016-08-31 01:31:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-31 01:31:36]

Dry run: This issue passed the CQ dry run.

[tandrii(chromium), 2016-08-31 10:17:43]

On 2016/08/31 01:27:36, M-A Ruel wrote:
> lgtm
> 
> I hadn't done it because I didn't want to take the time to do it thoroughly.
I'm
> that lazy.

I don't intend to convert everything from v2 to v42 either (i'm also lazy).

[tandrii(chromium), 2016-08-31 10:18:06]

and before you take away your LG-TM, i'm landing this :P

[tandrii(chromium), 2016-08-31 10:20:15]

The CQ bit was checked by tandrii@chromium.org

[commit-bot: I haz the power, 2016-08-31 10:20:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 10:26:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-31 10:26:30]

Try jobs failed on following builders:
  Depot Tools Presubmit on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/30f8f19dee62d110)

[tandrii(chromium), 2016-08-31 10:34:37]

amazing, so adding new file runs all tests which depend on git cl support for
svn and hence CQ aborts.

[tandrii(chromium), 2016-08-31 10:36:43]

Description was changed from

==========
It's time to bring subprocess42 to depot_tools.

The immediate need is to properly kill git fetch and its sub-spawned
process from gclient.

R=maruel@chromium.org,hinoka@chromium.org
BUG=635641
==========

to

==========
It's time to bring subprocess42 to depot_tools.

The immediate need is to properly kill git fetch and its sub-spawned
process from gclient.

R=maruel@chromium.org, hinoka@chromium.org
BUG=635641

Committed:
https://chromium.googlesource.com/chromium/tools/depot_tools/+/6d3c2901643609...
==========

[tandrii(chromium), 2016-08-31 10:36:45]

Committed patchset #1 (id:1) manually as
6d3c290164360907fe08784093e36314069e689f (presubmit successful).

[M-A Ruel, 2016-08-31 13:43:33]

On 2016/08/31 10:17:43, tandrii(chromium) wrote:
> On 2016/08/31 01:27:36, M-A Ruel wrote:
> > lgtm
> > 
> > I hadn't done it because I didn't want to take the time to do it thoroughly.
> I'm
> > that lazy.
> 
> I don't intend to convert everything from v2 to v42 either (i'm also lazy).

ARGhhlglglgl

[tandrii(chromium), 2016-08-31 17:58:17]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2295043003/ by tandrii@chromium.org.

The reason for reverting is: Speculative revert because it might be breaking
presubmit in depot_tools..