Handling errors from chrome APIs

chrome/browser/resources/google_now/utility.js

Index: chrome/browser/resources/google_now/utility.js
diff --git a/chrome/browser/resources/google_now/utility.js b/chrome/browser/resources/google_now/utility.js
index 57db70678714ed73cfce7492e09edc7741411d12..7878ac4652eb23ad494603f35b269bb858a95fe7 100644
--- a/chrome/browser/resources/google_now/utility.js
+++ b/chrome/browser/resources/google_now/utility.js
@@ -504,6 +504,10 @@ function buildAttemptManager(
    */
   function planForNext(callback) {
     instrumented.storage.local.get(currentDelayStorageKey, function(items) {
+      if (!items) {
+        items = {};

[rgustafson, 2013/08/22 00:46:14]

why not items.currentDelayStorageKey like everything else?

[rgustafson, 2013/08/22 00:49:53]

I just answered that for myself right after asking it. :)

+        items[currentDelayStorageKey] = maximumDelaySeconds;
+      }
       console.log('planForNext-get-storage ' + JSON.stringify(items));
       scheduleNextAttempt(items[currentDelayStorageKey]);
       callback();
@@ -554,15 +558,15 @@ function buildAuthenticationManager() {
   /**
    * Removes the specified cached token.
    * @param {string} token Authentication Token to remove from the cache.
-   * @param {function} onSuccess Called on completion.
+   * @param {function} callback Called on completion.
    */
-  function removeToken(token, onSuccess) {
+  function removeToken(token, callback) {
     instrumented.identity.removeCachedAuthToken({token: token}, function() {
       // Removing the token from the cache will change the sign in state.
       // Repoll now to check the state and notify listeners.
       // This also lets Chrome now about a possible problem with the token.
       isSignedIn(function() {});
-      onSuccess();
+      callback();
     });
   }