Handling errors from chrome APIs

chrome/browser/resources/google_now/utility.js

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 'use strict';
 
 /**
  * @fileoverview Utility objects and functions for Google Now extension.
  */
 
@@ skipping 486 matching lines @@
     chrome.storage.local.remove(currentDelayStorageKey);
   }
 
   /**
    * Plans for the next attempt.
    * @param {function()} callback Completion callback. It will be invoked after
    *     the planning is done.
    */
   function planForNext(callback) {
     instrumented.storage.local.get(currentDelayStorageKey, function(items) {
+      if (!items) {
+        items = {};

[rgustafson, 2013/08/22 00:46:14]

why not items.currentDelayStorageKey like everything else?

[rgustafson, 2013/08/22 00:49:53]

I just answered that for myself right after asking it. :)

+        items[currentDelayStorageKey] = maximumDelaySeconds;
+      }
       console.log('planForNext-get-storage ' + JSON.stringify(items));
       scheduleNextAttempt(items[currentDelayStorageKey]);
       callback();
     });
   }
 
   instrumented.alarms.onAlarm.addListener(function(alarm) {
     if (alarm.name == alarmName)
       isRunning(function(running) {
         if (running)
@@ skipping 30 matching lines @@
     instrumented.identity.getAuthToken({interactive: false}, function(token) {
       token = chrome.runtime.lastError ? undefined : token;
       callback(token);
       checkAndNotifyListeners(!!token);
     });
   }
 
   /**
    * Removes the specified cached token.
    * @param {string} token Authentication Token to remove from the cache.
-   * @param {function} onSuccess Called on completion.
+   * @param {function} callback Called on completion.
    */
-  function removeToken(token, onSuccess) {
+  function removeToken(token, callback) {
     instrumented.identity.removeCachedAuthToken({token: token}, function() {
       // Removing the token from the cache will change the sign in state.
       // Repoll now to check the state and notify listeners.
       // This also lets Chrome now about a possible problem with the token.
       isSignedIn(function() {});
-      onSuccess();
+      callback();
     });
   }
 
   var listeners = [];
 
   /**
    * Registers a listener that gets called back when the signed in state
    * is found to be changed.
    * @param {function} callback Called when the answer to isSignedIn changes.
    */
@@ skipping 24 matching lines @@
   // Poll for the sign in state every hour.
   // One hour is just an arbitrary amount of time chosen.
   chrome.alarms.create(alarmName, {periodInMinutes: 60});
 
   return {
     addListener: addListener,
     isSignedIn: isSignedIn,
     removeToken: removeToken
   };
 }