Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Unified Diff: content/browser/media/session/media_session_delegate_android.h

Issue 2291163002: Let MediaSession store duck state instead of volume multiplier (Closed)
Patch Set: addressed Anton's comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/media/session/media_session_delegate_android.h
diff --git a/content/browser/media/session/media_session_delegate_android.h b/content/browser/media/session/media_session_delegate_android.h
index 833aa8a93130e53dfca7f98872298b47d70f2431..8fe24b7e7c4d3d142475ff35e6d5dddf2fe13e9f 100644
--- a/content/browser/media/session/media_session_delegate_android.h
+++ b/content/browser/media/session/media_session_delegate_android.h
@@ -37,12 +37,15 @@ class MediaSessionDelegateAndroid : public MediaSessionDelegate {
// Called by Java through JNI.
void OnResume(JNIEnv* env, const base::android::JavaParamRef<jobject>& obj);
- // Called when the Android system requests the MediaSession to duck.
+ // Called when the Android system requests the MediaSession to start ducking.
// Called by Java through JNI.
- void OnSetVolumeMultiplier(JNIEnv* env, jobject obj,
- jdouble volume_multiplier);
+ void OnStartDucking(JNIEnv* env, jobject obj);
- // Called when the Android system requests the MediaSession to duck.
+ // Called when the Android system requests the MediaSession to stop ducking.
+ // Called by Java through JNI.
+ void OnStopDucking(JNIEnv* env, jobject obj);
+
+ // Record when the Android system requests the MediaSession to duck.
// Called by Java through JNI.
void RecordSessionDuck(JNIEnv* env,
const base::android::JavaParamRef<jobject> &obj);

Powered by Google App Engine
This is Rietveld 408576698