Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 2291153003: In update-w3c-test-expectations, only rebaseline newly-changed tests. (Closed)

Created:
4 years, 3 months ago by qyearsley
Modified:
4 years, 3 months ago
Reviewers:
Dirk Pranke
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, Dirk Pranke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

In update-w3c-test-expectations, only rebaseline newly-changed tests. Reason: When downloading expectations for newly imported/updated w3c tests, we only want to download baselines for tests that are modified in the CL, because w3c test update CLs only modify tests (not Blink source code). This should prevent downloading baselines for other tests that failed on the try bots on some platform. BUG=629275 Committed: https://crrev.com/9a34bc3cf231cec8694e70ad61ec57a1f4986a21 Cr-Commit-Position: refs/heads/master@{#415787}

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/update_w3c_test_expectations.py View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
qyearsley
4 years, 3 months ago (2016-08-30 23:24:10 UTC) #3
Dirk Pranke
lgtm
4 years, 3 months ago (2016-08-31 04:38:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2291153003/1
4 years, 3 months ago (2016-08-31 16:31:19 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/289884)
4 years, 3 months ago (2016-08-31 19:32:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2291153003/20001
4 years, 3 months ago (2016-08-31 21:10:15 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-31 22:36:07 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 22:39:36 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9a34bc3cf231cec8694e70ad61ec57a1f4986a21
Cr-Commit-Position: refs/heads/master@{#415787}

Powered by Google App Engine
This is Rietveld 408576698