Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 2291143003: Free the GifPlainText object when complete. (Closed)

Created:
4 years, 3 months ago by dsinclair
Modified:
4 years, 3 months ago
Reviewers:
Lei Zhang, Wei Li
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Free the GifPlainText object when complete. We allocate the GifPlainText object on line ~685 inside GIF_D_STATUS_EXT_PTE. We cleanup the internal pointers in the gif_destroy_decompress() but we failed to cleanup the pointer itself. This CL frees the allocated pointer once the data is cleaned up. BUG=chromium:638499 Committed: https://pdfium.googlesource.com/pdfium/+/87dffc0315477150c9c1964913b65bc97bdf654f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M core/fxcodec/lgif/fx_gif.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
dsinclair
PTAL.
4 years, 3 months ago (2016-08-30 20:22:30 UTC) #4
Wei Li
lgtm
4 years, 3 months ago (2016-08-30 21:28:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2291143003/1
4 years, 3 months ago (2016-08-31 13:03:38 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 13:03:54 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/87dffc0315477150c9c1964913b65bc97bdf...

Powered by Google App Engine
This is Rietveld 408576698