DescriptionRe-land: Move ChromeVox loading out of ComponentLoader.
Original changelist: http://crrev.com/2212853002
This change landed and was then reverted because it broke ChromeVox when
logging in when it was already enabled on the login screen. The issue was
that AccessibilityManager needed to add the component extension to each
profile.
The immediate benefit is that ComponentLoader doesn't need to depend on
AccessibilityManager - previously they both depended on each other.
The end goal is to refactor AccessibilityManager so that it can support
multiple accessibility component extensions. Rather than a separate function
in ComponentLoader to load each one, I think it'd make more sense for
AccessibilityManager to just call ComponentLoader with the appropriate
parameters like the extension id and path.
BUG=634233
TEST=Toggle ChromeVox on/off from login screen, logged-in session, and guest session. Enable ChromeVox in login screen and log in, ensure ChromeVox remains on. Try with both ChromeVox Classic and Next.
Committed: https://crrev.com/2c0132079532714ac3628568ef3ecd3826a39c18
Cr-Commit-Position: refs/heads/master@{#417038}
Patch Set 1 #Patch Set 2 : Add ChromeVox to this profile if needed #
Total comments: 2
Patch Set 3 : Update component_loader comment #
Messages
Total messages: 17 (10 generated)
|