Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1098)

Issue 2291123006: Do not use |target_os="chromeos"| for libFuzzer and AFL build configurations. (Closed)

Created:
4 years, 3 months ago by mmoroz
Modified:
4 years, 3 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not use |target_os="chromeos"| for libFuzzer and AFL build configurations. Usage of 'chromeos_with_codecs' mixin, that adds target_os="chromeos", leads to loosing of 36 active and 3 disabled fuzzers. This CL doesn't lead to loosing of any fuzzers and also brings back those 36 and 3 fuzzers. R=aizatsky@chromium.org, dalecurtis@chromium.org, dpranke@chromium.org, inferno@chromium.org BUG=638935 Committed: https://crrev.com/eca2d62e8ed9d068f34c0241d5b748c51bc0b2b5 Cr-Commit-Position: refs/heads/master@{#415638}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M tools/mb/mb_config.pyl View 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
mmoroz
4 years, 3 months ago (2016-08-31 12:44:52 UTC) #1
mmoroz
On 2016/08/31 12:44:52, mmoroz wrote: Please take a look at this tiny CL once you ...
4 years, 3 months ago (2016-08-31 12:47:08 UTC) #3
inferno
lgtm
4 years, 3 months ago (2016-08-31 14:35:59 UTC) #7
Paweł Hajdan Jr.
LGTM
4 years, 3 months ago (2016-08-31 14:38:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2291123006/1
4 years, 3 months ago (2016-08-31 15:06:25 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-31 15:25:56 UTC) #13
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/eca2d62e8ed9d068f34c0241d5b748c51bc0b2b5 Cr-Commit-Position: refs/heads/master@{#415638}
4 years, 3 months ago (2016-08-31 15:27:37 UTC) #15
Dirk Pranke
4 years, 3 months ago (2016-08-31 16:14:03 UTC) #16
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698