Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issue 2291123003: Enable milo pubsub on public buildbot chromium/os masters (Closed)

Created:
4 years, 3 months ago by Ryan Tseng
Modified:
4 years, 3 months ago
Reviewers:
Vadim Sh., estaab
CC:
chromium-reviews, infra-reviews+build_chromium.org, smut
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Enable milo pubsub on public buildbot chromium/os masters BUG=642461 Committed: https://chromium.googlesource.com/chromium/tools/build/+/b33935c6be58d166080ab9dd93a25c40a8671966

Patch Set 1 #

Patch Set 2 : builder.pyl #

Patch Set 3 : Revert alt_port changes and chromiumos.tryserver changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -0 lines) Patch
M masters/master.chromium.android/builders.pyl View 1 1 chunk +1 line, -0 lines 0 comments Download
M masters/master.chromium.android/master_site_config.py View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M masters/master.chromium.chromedriver/master_site_config.py View 1 chunk +3 lines, -0 lines 0 comments Download
M masters/master.chromium.gatekeeper/master_site_config.py View 1 chunk +3 lines, -0 lines 0 comments Download
M masters/master.chromium.goma/builders.pyl View 1 1 chunk +1 line, -0 lines 0 comments Download
M masters/master.chromium.goma/master_site_config.py View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M masters/master.chromium.gpu.fyi/master_site_config.py View 1 chunk +3 lines, -0 lines 0 comments Download
M masters/master.chromium.gpu/master_site_config.py View 1 chunk +3 lines, -0 lines 0 comments Download
M masters/master.chromium.infra.cron/master_site_config.py View 1 chunk +3 lines, -0 lines 0 comments Download
M masters/master.chromium.lkgr/master_site_config.py View 1 chunk +3 lines, -0 lines 0 comments Download
M masters/master.chromium.memory.full/master_site_config.py View 1 chunk +3 lines, -0 lines 0 comments Download
M masters/master.chromium.perf.fyi/master_site_config.py View 1 chunk +3 lines, -0 lines 0 comments Download
M masters/master.chromium.perf/master_site_config.py View 1 chunk +3 lines, -0 lines 0 comments Download
M masters/master.chromium.swarm/master_site_config.py View 1 chunk +3 lines, -0 lines 0 comments Download
M masters/master.chromium.tools.build/builders.pyl View 1 1 chunk +1 line, -0 lines 0 comments Download
M masters/master.chromium.tools.build/master_site_config.py View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M masters/master.chromium.webrtc.fyi/master_site_config.py View 1 chunk +3 lines, -0 lines 0 comments Download
M masters/master.chromium.webrtc/master_site_config.py View 1 chunk +3 lines, -0 lines 0 comments Download
M masters/master.chromiumos.chromium/master_site_config.py View 1 chunk +3 lines, -0 lines 0 comments Download
M masters/master.chromiumos/master_site_config.py View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (17 generated)
Ryan Tseng
some port updates got rolled into this because i regenerated builder.pyl, i guess no one ...
4 years, 3 months ago (2016-08-30 20:30:56 UTC) #8
estaab
[+someone more knowledgeable than me and cc'ing trooper] lgtm, but please ask Vadim if this ...
4 years, 3 months ago (2016-08-30 21:54:18 UTC) #12
Vadim Sh.
master_port_alt changes are sort of important. Work with labs to update Apache config accordingly. Otherwise ...
4 years, 3 months ago (2016-08-30 22:05:12 UTC) #13
Ryan Tseng
I reverted the alt_port changes since they're out of scope, they'll be fixed in a ...
4 years, 3 months ago (2016-08-30 22:49:35 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2291123003/40001
4 years, 3 months ago (2016-08-31 17:23:49 UTC) #21
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 17:28:08 UTC) #23
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/tools/build/+/b33935c6be58d166080a...

Powered by Google App Engine
This is Rietveld 408576698