Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 2291103002: [TurboFan]: Rename "upper" types to just types. (Closed)

Created:
4 years, 3 months ago by mvstanton
Modified:
4 years, 3 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[TurboFan]: Rename "upper" types to just types. BUG= Committed: https://crrev.com/cc9d44980b7367cf9553c63a7e9915d85df4c11d Cr-Commit-Position: refs/heads/master@{#39020}

Patch Set 1 #

Patch Set 2 : Removed simplified-lowering. #

Patch Set 3 : nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -98 lines) Patch
M src/compiler/simplified-lowering.cc View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M src/compiler/verifier.cc View 38 chunks +94 lines, -94 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
mvstanton
Hi Jaro, Here is the simple change we discussed.
4 years, 3 months ago (2016-08-30 12:46:54 UTC) #2
Jarin
lgtm
4 years, 3 months ago (2016-08-30 12:50:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2291103002/40001
4 years, 3 months ago (2016-08-30 12:57:31 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/22879)
4 years, 3 months ago (2016-08-30 13:01:22 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2291103002/60001
4 years, 3 months ago (2016-08-30 14:02:02 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 3 months ago (2016-08-30 14:27:38 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 14:27:56 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/cc9d44980b7367cf9553c63a7e9915d85df4c11d
Cr-Commit-Position: refs/heads/master@{#39020}

Powered by Google App Engine
This is Rietveld 408576698