Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Unified Diff: components/nacl/common/nacl_helper_linux.h

Issue 22911027: Pass StatsTable shared memory via global descriptors on Posix rather than using named shared memory. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update kNaClSandboxDescriptor. Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/metrics/stats_table.cc ('k') | content/browser/child_process_launcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/nacl/common/nacl_helper_linux.h
diff --git a/components/nacl/common/nacl_helper_linux.h b/components/nacl/common/nacl_helper_linux.h
index a9324b3fa1d786a2cd705bcad2d33cd36b9747ca..9f6c31d665c69a35417ccf3390437b004e52cda3 100644
--- a/components/nacl/common/nacl_helper_linux.h
+++ b/components/nacl/common/nacl_helper_linux.h
@@ -28,10 +28,10 @@ enum NaClZygoteIPCCommand {
#define kNaClZygoteDescriptor 3
// For communications between the NaCl loader process and
// the SUID sandbox.
-#define kNaClSandboxDescriptor 5
+#define kNaClSandboxDescriptor 6
// NOTE: kNaClSandboxDescriptor must match
-// content/browser/zygote_main_linux.cc
-// kMagicSandboxIPCDescriptor.
+// content/public/common/content_descriptors.h
+// kSandboxIPCChannel + base::GlobalDescriptors::kBaseDescriptor
Mark Seaborn 2013/10/14 22:01:50 Would you mind removing kNaClSandboxDescriptor fro
rmcilroy 2013/10/15 18:47:50 Done.
// A fork request from the Zygote to the helper includes an array
// of three file descriptors. These constants are used as indicies
« no previous file with comments | « base/metrics/stats_table.cc ('k') | content/browser/child_process_launcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698