ipc/ipc_descriptors.h - Issue 22911027: Pass StatsTable shared memory via global descriptors on Posix rather than using named shared memory.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ipc/ipc_descriptors.h

Issue 22911027: Pass StatsTable shared memory via global descriptors on Posix rather than using named shared memory. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Really fix Windows build... Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef IPC_IPC_DESCRIPTORS_H_	5 #ifndef IPC_IPC_DESCRIPTORS_H_

6 #define IPC_IPC_DESCRIPTORS_H_	6 #define IPC_IPC_DESCRIPTORS_H_

7	7

8 // This is a list of global descriptor keys to be used with the	8 // This is a list of global descriptor keys to be used with the

9 // base::GlobalDescriptors object (see base/posix/global_descriptors.h)	9 // base::GlobalDescriptors object (see base/posix/global_descriptors.h)

10 enum {	10 enum {

11 kPrimaryIPCChannel = 0,	11 kPrimaryIPCChannel = 0,

	12 kStatsTableSharedMemFd = 100,
	jam 2013/08/25 16:27:20 this seems a bit hacky. please copy what chrome/co this seems a bit hacky. please copy what chrome/content use, i.e. how content defines kContentIPCDescriptorMax and chrome begins after that. so here we should have kIPCDescriptorMax that content keys off, since the code assumed so far that IPC layer only had one fd rmcilroy 2013/08/27 14:13:06 You're right, I had meant to ask where ipc descrip Show quoted text On 2013/08/25 16:27:20, jam wrote: > this seems a bit hacky. please copy what chrome/content use, i.e. how content > defines kContentIPCDescriptorMax and chrome begins after that. so here we > should have kIPCDescriptorMax that content keys off, since the code assumed so > far that IPC layer only had one fd You're right, I had meant to ask where ipc descriptors were being registered and didn't know of content_descriptors.h. Done.
12 };	13 };

13	14

14 #endif // IPC_IPC_DESCRIPTORS_H_	15 #endif // IPC_IPC_DESCRIPTORS_H_

OLD	NEW

« content/browser/child_process_launcher.cc ('K') | « content/browser/child_process_launcher.cc ('k') | no next file » | no next file with comments »