Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Unified Diff: base/message_loop/message_pump_mac.h

Issue 22911026: Add instrumentation to the MessagePumpMac family of classes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add caveat Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/message_loop/message_pump.h ('k') | base/message_loop/message_pump_mac.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/message_loop/message_pump_mac.h
diff --git a/base/message_loop/message_pump_mac.h b/base/message_loop/message_pump_mac.h
index 748b26591f0403baaaa88fc9ad070135c8565f3b..424cb70938d058a90288ceb5314bf73c8ae3200c 100644
--- a/base/message_loop/message_pump_mac.h
+++ b/base/message_loop/message_pump_mac.h
@@ -36,6 +36,8 @@
#include <CoreFoundation/CoreFoundation.h>
+#include "base/memory/weak_ptr.h"
+
#if !defined(__OBJC__)
class NSAutoreleasePool;
#else // !defined(__OBJC__)
@@ -57,6 +59,7 @@ class NSAutoreleasePool;
namespace base {
+class MessagePumpInstrumentation;
class RunLoop;
class TimeTicks;
@@ -93,6 +96,11 @@ class MessagePumpCFRunLoopBase : public MessagePump {
// objects autoreleased by work to fall into the current autorelease pool.
virtual NSAutoreleasePool* CreateAutoreleasePool();
+ // Enables instrumentation of the MessagePump. See MessagePumpInstrumentation
+ // in the implementation for details.
+ void EnableInstrumentation();
+ WeakPtr<MessagePumpInstrumentation> instrumentation_;
+
private:
// Timer callback scheduled by ScheduleDelayedWork. This does not do any
// work, but it signals work_source_ so that delayed work can be performed
@@ -106,11 +114,11 @@ class MessagePumpCFRunLoopBase : public MessagePump {
static void RunWorkSource(void* info);
bool RunWork();
- // Perform idle-priority work. This is normally called by PreWaitObserver,
- // but is also associated with idle_work_source_. When this function
- // actually does perform idle work, it will resignal that source. The
- // static method calls the instance method; the instance method returns
- // true if idle work was done.
+ // Perform idle-priority work. This is normally called by
+ // StartOrEndWaitObserver, but is also associated with idle_work_source_. When
+ // this function actually does perform idle work, it will resignal that
+ // source. The static method calls the instance method; the instance method
+ // returns true if idle work was done.
static void RunIdleWorkSource(void* info);
bool RunIdleWork();
@@ -132,8 +140,8 @@ class MessagePumpCFRunLoopBase : public MessagePump {
// Observer callback responsible for performing idle-priority work, before
// the run loop goes to sleep. Associated with idle_work_observer_.
- static void PreWaitObserver(CFRunLoopObserverRef observer,
- CFRunLoopActivity activity, void* info);
+ static void StartOrEndWaitObserver(CFRunLoopObserverRef observer,
+ CFRunLoopActivity activity, void* info);
// Observer callback called before the run loop processes any sources.
// Associated with pre_source_observer_.
« no previous file with comments | « base/message_loop/message_pump.h ('k') | base/message_loop/message_pump_mac.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698