Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2172)

Unified Diff: cc/layers/nine_patch_layer.cc

Issue 22911024: Fix crashes when NinePatchLayer doesn't have a resource. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@shadow
Patch Set: Move needs_push_properties_ from Update to PPT Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | cc/layers/nine_patch_layer_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/layers/nine_patch_layer.cc
diff --git a/cc/layers/nine_patch_layer.cc b/cc/layers/nine_patch_layer.cc
index e32f6e0b125230633449e3141994ee2c81d82bed..517b49b68fc50ad69e0da9d722a8ccd59de88bb2 100644
--- a/cc/layers/nine_patch_layer.cc
+++ b/cc/layers/nine_patch_layer.cc
@@ -72,6 +72,7 @@ bool NinePatchLayer::Update(ResourceUpdateQueue* queue,
bitmap_dirty_ = false;
updated = true;
}
+
return updated;
}
@@ -111,6 +112,11 @@ void NinePatchLayer::PushPropertiesTo(LayerImpl* layer) {
layer_impl->SetLayout(
gfx::Size(bitmap_.width(), bitmap_.height()), image_aperture_);
}
+
+ // NinePatchLayer must push properties every commit to make sure
+ // NinePatchLayerImpl::resource_id_ is valid.
+ // http://crbug.com/276482
+ needs_push_properties_ = true;
}
} // namespace cc
« no previous file with comments | « no previous file | cc/layers/nine_patch_layer_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698