Issue 22911019: [DOM4] Have ProcessingInstruction inherit CharacterData

Issue 22911019: [DOM4] Have ProcessingInstruction inherit CharacterData (Closed)

Created:
7 years, 4 months ago by do-not-use

Modified:
7 years, 4 months ago

Reviewers:
haraken, arv (Not doing code reviews), jochen (gone - plz use gerrit)

CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

[DOM4] Have ProcessingInstruction inherit CharacterData Have ProcessingInstruction inherit CharacterData as per the latest DOM4 specification: http://dom.spec.whatwg.org/#processinginstruction Previously, ProcessingInstruction was inheriting from Node as per DOM Level 3. Firefox already follows DOM4 but not IE10. This change leads to less code duplication. BUG=275465 R=haraken@chromium.org, jochen@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156390

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+66 lines, -48 lines)			Patch
M	LayoutTests/fast/dom/coreDOM-element-attribute-js-null.xhtml	View	1 chunk	+1 line, -1 line	0 comments	Download
M	LayoutTests/fast/dom/coreDOM-element-attribute-js-null-expected.txt	View	1 chunk	+1 line, -1 line	0 comments	Download
A	LayoutTests/fast/dom/processing-instruction-inherit-characterdata.xhtml	View	1 chunk	+27 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/dom/processing-instruction-inherit-characterdata-expected.txt	View	1 chunk	+17 lines, -0 lines	0 comments	Download
M	Source/core/dom/CharacterData.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	Source/core/dom/CharacterData.cpp	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	Source/core/dom/ProcessingInstruction.h	View	5 chunks	+9 lines, -9 lines	0 comments	Download
M	Source/core/dom/ProcessingInstruction.cpp	View	7 chunks	+4 lines, -33 lines	0 comments	Download
M	Source/core/dom/ProcessingInstruction.idl	View	1 chunk	+1 line, -2 lines	0 comments	Download

Total messages: 6 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/22911019/1

7 years, 4 months ago (2013-08-20 09:06:47 UTC) #4

do-not-use

Committed patchset #1 manually as r156390 (presubmit successful).

7 years, 4 months ago (2013-08-20 12:37:00 UTC) #5

Message was sent while issue was closed.

LGTM