Update how SkPath handles fGenerationID and fSourcePath, and add tests to cover.

Update how SkPath handles fGenerationID and fSourcePath, and add tests to cover.

BUG=
R=bungeman@google.com, reed@google.com

Committed: https://code.google.com/p/skia/source/detail?r=10756

[mtklein, 2013-08-12 18:37:51]

See if this jives with what you recommended?

[romainguy, 2013-08-12 18:40:56]

It looks good to me, thanks! I'll let you know when (if) we switch to a cleaner
way of doing this.

[mtklein, 2013-08-12 18:55:00]

Ben, can you take a look so I can have a review from someone on the team too?

[bungeman-skia, 2013-08-12 19:13:31]

Aside from this being a really odd coupling, this change lgtm with the one nit.

https://codereview.chromium.org/22911002/diff/4001/src/core/SkPath.cpp
File src/core/SkPath.cpp (right):

https://codereview.chromium.org/22911002/diff/4001/src/core/SkPath.cpp#newcod...
src/core/SkPath.cpp:183: // We don't touch fSourcePath.  It's ued to track
texture garbage collection, so we don't
s/ued/used

[mtklein, 2013-08-12 19:19:36]

https://codereview.chromium.org/22911002/diff/4001/src/core/SkPath.cpp
File src/core/SkPath.cpp (right):

https://codereview.chromium.org/22911002/diff/4001/src/core/SkPath.cpp#newcod...
src/core/SkPath.cpp:183: // We don't touch fSourcePath.  It's ued to track
texture garbage collection, so we don't
On 2013/08/12 19:13:31, bungeman1 wrote:
> s/ued/used

Done.

[reed1, 2013-08-15 21:14:13]

lgtm

[mtklein, 2013-08-15 21:15:39]

Committed patchset #4 manually as r10756 (presubmit successful).