Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 2291043002: [wasm] Use the native_context for the TypeError in ToJS() (Closed)

Created:
4 years, 3 months ago by ahaas
Modified:
4 years, 3 months ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Use the native_context for the TypeError in ToJS() With this CL we use isolate->native_context() to provide a context for the CEntryStub of the runtime call. The native_context() is sufficient here because Runtime::kWasmThrowTypeError does not use the context. R=titzer@chromium.org TEST=mjsunit/wasm/ffi-error.js BUG=chromium:639492 Committed: https://crrev.com/510246f6e23b2c5ff7319b9be2384f2285243f9e Cr-Commit-Position: refs/heads/master@{#39014}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -4 lines) Patch
M src/compiler/wasm-compiler.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M test/mjsunit/wasm/ffi-error.js View 1 chunk +20 lines, -0 lines 0 comments Download
M test/mjsunit/wasm/wasm-constants.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
ahaas
4 years, 3 months ago (2016-08-30 11:21:51 UTC) #1
titzer
On 2016/08/30 11:21:51, ahaas wrote: lgtm
4 years, 3 months ago (2016-08-30 12:20:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2291043002/1
4 years, 3 months ago (2016-08-30 12:42:55 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-30 12:45:51 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 12:46:09 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/510246f6e23b2c5ff7319b9be2384f2285243f9e
Cr-Commit-Position: refs/heads/master@{#39014}

Powered by Google App Engine
This is Rietveld 408576698